394486 - GetShortPathNameW is slow

Status: RESOLVED WONTFIX

(Firefox :: File Handling, defect)

Description

[Stuart Parmenter]

I've been profiling startup and noticing that we're spending quite a bit of time in GetShortPathNameW().  The main offender is from this stack:

GetShortPathNameW
nsLocalFile.EnsureShortPath
nsLocalFile.Equals
IndexOfDirectoryOfFile
xptiSortFileList
NS_QuickSort
xptiInterfaceInfoManager.BuildOrderedFileArray
xptiInterfaceInfoManager.DoFullValidationMergeFromFileList
xptiInterfaceInfoManager.AutoRegisterInterfaces
xptiInterfaceInfoManager.GetInterfaceInfoManagerNoAddRef
NS_InitXPCOM3_P


Now that we no longer support Win95/98/ME can we get away with either converting short file names to long filenames to avoid conflicts or just doing away with this code entirely?

Comment 1

[Benjamin Smedberg]

We cannot do away with the code entirely, but I'm pretty sure we can try normalizing to long paths to see if that's less expensive.

Comment 2

[Florian Quèze [:florian]]

nsLocalFile.Equals still calls EnsureShortPath which calls ::GetShortPathName. But I really doubt we still do any of this during startup (especially now that xpt files are in omni.ja), so I think this is either worksforme or wontfix.