394490 - Pending .extra and .dmp files should be deleted if was chosen to not submit the crash report to Mozilla

Status: RESOLVED FIXED

(Toolkit :: Crash Reporting, defect)

Description

[Martijn Wargers (dead)]

I got a lot of files in:
C:\Documents and Settings\mw\Application Data\Mozilla\Firefox\Crash Reports\pending
It turns out these files are being made every time you crash.
But when you chose to not send the crash report to Mozilla, those files are not deleted.
They are being deleted when you do chose to submit the crash report to Mozilla.

Comment 1

[timeless]

a coworker chose not to send reports.

i expected to be able to send them later. the wording is ambiguous. i'd be upset if no meant deleting them.

i can't send reports because of firewalls, others can't because of vista.

but i can use windbg on the dmp files.

Comment 2

[Martijn Wargers (dead)]

Fwiw, I don't expect them to send them later. I don't even know how to do that.

This is particularly annoying for me, since these files keep piling up here. Again, I had to clean up that directory, because > 1700 files with >50MB was lying around there.

Also files at: C:\Documents and Settings\mw\Application Data\Mozilla\Firefox\Crash Reports
seem to be piling up there, named InstallTime2007091604 for instance. I now have 43 files of these kind there.

Comment 3

[(not currently active) Ted Mielczarek]

This will also block re-sending reports that failed to submit, since we currently don't distinguish between reports that failed to submit, and reports that were never submitted.

Martijn: I don't see the InstallTime$BUILDID as a big problem, as "normal" users will only ever get new ones when they update to a new version.  Only nightly testers will ever get a significant amount of those, and it's quite safe to delete them.

Comment 4

[(not currently active) Ted Mielczarek]

Also, timeless: there's an environment variable you could use: MOZ_CRASHREPORTER_NO_DELETE_DUMP

See http://developer.mozilla.org/en/docs/Environment_variables_affecting_crash_reporting

Comment 5

[(not currently active) Ted Mielczarek]

Attachment: WIP patch

Working on this so I can fix bug 378528.  Here's a WIP patch with Windows support.

Comment 6

[(not currently active) Ted Mielczarek]

Attachment: WIP win + linux

+ Linux

Comment 7

[(not currently active) Ted Mielczarek]

Attachment: complete patch

Finished.  Gonna conflict my other mac patch, but such is life.

Comment 8

[(not currently active) Ted Mielczarek]

Comment on attachment 298796 [details] [diff] [review]
complete patch

Pre-requisite for bug 378528 (which is a blocker).

Comment 9

[Mike Beltzner [:beltzner, not reading bugmail]]

Comment on attachment 298796 [details] [diff] [review]
complete patch

a=beltzner for 1.9

Comment 10

[(not currently active) Ted Mielczarek]

Checked in.