If you think a bug might affect users in the 57 release, please set the correct tracking and status flags for Release Management.

Pending .extra and .dmp files should be deleted if was chosen to not submit the crash report to Mozilla

RESOLVED FIXED

Status

()

Toolkit
Crash Reporting
RESOLVED FIXED
10 years ago
10 years ago

People

(Reporter: Martijn Wargers (dead), Assigned: ted)

Tracking

Trunk
x86
Windows XP
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 2 obsolete attachments)

(Reporter)

Description

10 years ago
I got a lot of files in:
C:\Documents and Settings\mw\Application Data\Mozilla\Firefox\Crash Reports\pending
It turns out these files are being made every time you crash.
But when you chose to not send the crash report to Mozilla, those files are not deleted.
They are being deleted when you do chose to submit the crash report to Mozilla.

Comment 1

10 years ago
a coworker chose not to send reports.

i expected to be able to send them later. the wording is ambiguous. i'd be upset if no meant deleting them.

i can't send reports because of firewalls, others can't because of vista.

but i can use windbg on the dmp files.
(Reporter)

Comment 2

10 years ago
Fwiw, I don't expect them to send them later. I don't even know how to do that.

This is particularly annoying for me, since these files keep piling up here. Again, I had to clean up that directory, because > 1700 files with >50MB was lying around there.

Also files at: C:\Documents and Settings\mw\Application Data\Mozilla\Firefox\Crash Reports
seem to be piling up there, named InstallTime2007091604 for instance. I now have 43 files of these kind there.
This will also block re-sending reports that failed to submit, since we currently don't distinguish between reports that failed to submit, and reports that were never submitted.

Martijn: I don't see the InstallTime$BUILDID as a big problem, as "normal" users will only ever get new ones when they update to a new version.  Only nightly testers will ever get a significant amount of those, and it's quite safe to delete them.
Blocks: 378528
Also, timeless: there's an environment variable you could use: MOZ_CRASHREPORTER_NO_DELETE_DUMP

See http://developer.mozilla.org/en/docs/Environment_variables_affecting_crash_reporting
Created attachment 298609 [details] [diff] [review]
WIP patch

Working on this so I can fix bug 378528.  Here's a WIP patch with Windows support.
Assignee: nobody → ted.mielczarek
Status: NEW → ASSIGNED
Created attachment 298619 [details] [diff] [review]
WIP win + linux

+ Linux
Attachment #298609 - Attachment is obsolete: true
Created attachment 298796 [details] [diff] [review]
complete patch

Finished.  Gonna conflict my other mac patch, but such is life.
Attachment #298619 - Attachment is obsolete: true
Attachment #298796 - Flags: review?(dcamp)

Updated

10 years ago
Attachment #298796 - Flags: review?(dcamp) → review+
Comment on attachment 298796 [details] [diff] [review]
complete patch

Pre-requisite for bug 378528 (which is a blocker).
Attachment #298796 - Flags: approval1.9?
Comment on attachment 298796 [details] [diff] [review]
complete patch

a=beltzner for 1.9
Attachment #298796 - Flags: approval1.9? → approval1.9+
Checked in.
Status: ASSIGNED → RESOLVED
Last Resolved: 10 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.