394510 - text run leak on garbled input

Status: RESOLVED FIXED

(Core Graveyard :: GFX, defect)

Description

[Robert Sayre]

The text at the URL is garbled. Caught this with a new script I have that walks the Web for random URLs and checks for leaks.

HTTP/1.1 200 OK
Date: Fri, 31 Aug 2007 23:05:36 GMT
Server: Apache/1.3.37 (Unix) mod_ssl/2.8.28 OpenSSL/0.9.7e-p1
Last-Modified: Mon, 02 Jul 2007 11:14:26 GMT
ETag: "2ebdf96-182c-4688de12"
Accept-Ranges: bytes
Content-Length: 6188
Connection: close
Content-Type: text/html

Comment 1

[Robert Sayre]

Attachment: garbled page

Comment 2

[Robert O'Callahan (:roc) (email my personal email if necessary)]

What did you use to detect the leak? I ran with XPCOM_MEM_LEAK_LOG=2 XPCOM_MEM_LOG_CLASSES=gfxTextRun, loaded the page, and then shut down, and I didn't see any leaks of gfxTextRun.

Comment 3

[Robert Sayre]

I ran with XPCOM_MEM_LEAK_LOG=1 and launched like so:

"./firefox -foreground http://smashingmag.com/tour/02tr/021113primalken.html"

then quit. Still get it, but I will update my build and check again.

Comment 4

[Robert Sayre]

Comment on attachment 279173 [details]
garbled page

oops, this attachment doesn't leak, but the site does. will try to get something permanent in the bug.

Comment 5

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Attachment: plug leak

We're leaking the hyphen textrun that we create/use to measure and draw soft hyphens. This patch fixes that.

Comment 6

[Robert O'Callahan (:roc) (email my personal email if necessary)]

checked in.