Closed Bug 394528 Opened 13 years ago Closed 13 years ago
SSLThread leaks load groups
Robert Sayre found this through some automated testing of random URLs from delicious. Steps to reproduce: export XPCOM_MEM_LEAK_LOG=leak.log ./firefox http://www.muddlepuddle.co.uk/ Actual results: leak 1 nsLoadGroup Expected results: no nsLoadGroup leaked I suspect the problem is that nsHTTPDownloadEvent::Run is hitting the failure case that calls nsSSLThread::rememberPendingHTTPRequest(nsnull). The leak is fixed by the one-line patch to nsSSLThread::rememberPendingHTTPRequest to release the old value, but I have a better patch to convert mPendingHTTPRequest to an nsCOMPtr.
Screencast of how I found this is debugging session 6 at http://people.mozilla.com/~dbaron/leak-screencasts/
Comment on attachment 279190 [details] [diff] [review] patch Great, thanks David! r=kengert
Attachment #279190 - Flags: review?(kengert) → review+
Attachment #279190 - Flags: superreview?(bzbarsky)
Attachment #279190 - Flags: superreview?(bzbarsky) → superreview?(cbiesinger)
Comment on attachment 279190 [details] [diff] [review] patch sr=bzbarsky
Attachment #279190 - Flags: superreview?(cbiesinger) → superreview+
Attachment #279190 - Flags: approval1.9?
Fix checked in to trunk.
Status: NEW → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla1.9 M9
removing "blocking 1.9 ?", no longer required
You need to log in before you can comment on or make changes to this bug.