394528 - nsSSLThread leaks load groups

Status: RESOLVED FIXED

(Core :: Security: PSM, defect)

Description

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Robert Sayre found this through some automated testing of random URLs from delicious.

Steps to reproduce: 
  export XPCOM_MEM_LEAK_LOG=leak.log
  ./firefox http://www.muddlepuddle.co.uk/

Actual results: leak 1 nsLoadGroup
Expected results: no nsLoadGroup leaked

I suspect the problem is that nsHTTPDownloadEvent::Run is hitting the failure case that calls nsSSLThread::rememberPendingHTTPRequest(nsnull).  The leak is fixed by the one-line patch to nsSSLThread::rememberPendingHTTPRequest to release the old value, but I have a better patch to convert mPendingHTTPRequest to an nsCOMPtr.

Comment 1

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Attachment: patch

Comment 2

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Screencast of how I found this is debugging session 6 at http://people.mozilla.com/~dbaron/leak-screencasts/

Comment 3

[Kai Engert [:KaiE:]]

Comment on attachment 279190 [details] [diff] [review]
patch

Great, thanks David!

r=kengert

Comment 4

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 279190 [details] [diff] [review]
patch

sr=bzbarsky

Comment 5

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Fix checked in to trunk.

Comment 7

[Kai Engert [:KaiE:]]

removing "blocking 1.9 ?", no longer required