394585 - inconsistent case of "component" in title for select/delete component

Status: NEW

(Bugzilla :: Administration, task)

Description

[timeless]

Found 3 matching lines in 3 files
component
/template/en/default/admin/components/confirm-delete.html.tmpl,
    * line 28 -- [% title = BLOCK %]Delete component '[% comp.name FILTER html %]'
/template/en/default/admin/components/deleted.html.tmpl,
    * line 28 -- [% title = BLOCK %]Deleted Component '[% comp.name FILTER html %]' from Product
/template/en/default/admin/components/list.html.tmpl,
    * line 30 -- [% title = BLOCK %]Select component of product

Comment 1

[timeless]

Attachment: lowercase

Comment 2

[Frédéric Buclin]

Comment on attachment 279302 [details] [diff] [review]
lowercase

>-[% title = BLOCK %]Deleted Component '[% comp.name FILTER html %]' from Product
>+[% title = BLOCK %]Deleted component '[% comp.name FILTER html %]' from Product

lowercase for component, but uppercase for Product? I don't see more consistency here.

Comment 3

[timeless]

Attachment: lowercase both

Comment 4

[Frédéric Buclin]

Comment on attachment 279321 [details] [diff] [review]
lowercase both

Most titles use uppercase, some don't. If you want to be consistent, fix them all, else abstain.

Comment 5

[timeless]

Attachment: try to consistently use lowercase

The goal here is to recognize two styles:

Conjugated_verb other words
Noun Phrase

Basically, things like Deleted fall into the first category, and User Settings fall into the second.

I think that the second could probably be folded into the first by adding something like "Edit" or "Editing".

Comment 6

[Frédéric Buclin]

IMO, this kind of changes is not desired. Moreover, there are changes which look incorrect to me, such as changes submitted -> submitted changes. The title should explain the action taken. "submitted changes" looks wrong to me.

Comment 7

[Max Kanat-Alexander]

Comment on attachment 279546 [details] [diff] [review]
try to consistently use lowercase

One way or another, this patch is just too big for me to review.

However, I can confirm that titles should be appropriately in Title Case, and not "Sentence case."

Comment 8

[Frédéric Buclin]

We are going to branch for Bugzilla 4.4 next week and this bug is either too invasive to be accepted for 4.4 at this point or shows no recent activity. The target milestone is reset and will be set again *only* when a patch is attached and approved.

I ask the assignee to reassign the bug to the default assignee if you don't plan to work on this bug in the near future, to make it clearer which bugs should be fixed by someone else.