Extension Update URL broken when Extension is hosted on AMO

RESOLVED FIXED

Status

Mozilla Localizations
ro / Romanian
RESOLVED FIXED
11 years ago
8 years ago

People

(Reporter: Tomcat, Assigned: Iulian Ursache-Dogariu)

Tracking

({verified1.8.1.8})

unspecified
verified1.8.1.8
Bug Flags:
blocking1.8.1.8 +

Firefox Tracking Flags

(Not tracked)

Details

(URL)

Attachments

(1 attachment, 1 obsolete attachment)

(Reporter)

Description

11 years ago
http://mxr.mozilla.org/l10n-mozilla1.8/source/ro/toolkit/chrome/mozapps/extensions/extensions.properties#34 points to https://update.mozilla.org and this should be addons.mozilla.org

This cause errors like Eroare: channel.securityInfo has no properties
Fișier sursă: file:///C:/Program%20Files/Mozilla%20Firefox/components/nsExtensionManager.js
Rândul: 192

and 

Eroare: niciun element găsit
Fișier sursă: http://www.mozilla.com/?reqVersion=1&id=%7b5d1ffc76-4f99-11dc-8314-0800200c9a66%7d&version=1.00&maxAppVersion=2.0.0.*&appID=%7bec8030f7-c20a-464f-9b0e-13a3a9e97384%7d&appVersion=2.0.0.7pre&appOS=WINNT&appABI=x86-msvc
Rândul: 1, coloana: 1
Cod sursă:
^

in the Error Console while Checking extensions for Updates that are hosted on AMO

Reproduced with Mozilla/5.0 (Windows; U; Windows NT 5.1; ro; rv:1.8.1.7pre) Gecko/20070831 BonEcho/2.0.0.7pre and on Linux.

Also with the 2.0.0.6 Release ro Build.
Flags: blocking1.8.1.7?
(Reporter)

Updated

11 years ago
Summary: http://mxr.mozilla.org/l10n-mozilla1.8/source/ro/toolkit/chrome/mozapps/extensions/extensions.properties#34 points to wrong url → Extension Update URL broken when Extension is hosted on AMO
(Reporter)

Comment 1

11 years ago
also a problem:
line 35 and line 36  extensions.getMoreExtensionsURL=https://update.mozilla.org/extensions/?application=%APPID%
extensions.getMoreThemesURL=https://update.mozilla.org/themes/?application=%APPID%

Comment 2

11 years ago
This blocks un-betaing. Thanks to Carsten for finding this.
Blocks: 352125

Comment 3

11 years ago
Created attachment 279487 [details] [diff] [review]
Patch to replace update.mozilla.org with addons.mozilla.org

Don't know which approval needs to be set, if you could help here Axel, please.

Comment 4

11 years ago
Comment on attachment 279487 [details] [diff] [review]
Patch to replace update.mozilla.org with addons.mozilla.org

Sorry, this should be the same thing as in en-US,

http://bonsai.mozilla.org/cvsblame.cgi?file=mozilla%2Ftoolkit%2Flocales%2Fen-US%2Fchrome%2Fmozapps%2Fextensions%2Fextensions.properties&rev=&cvsroot=%2Fcvsroot&mark=42-44#42

For landing, you want to request approval1.8.1.7 by setting that flag to '?'
Attachment #279487 - Flags: review-
Flags: blocking1.8.1.7? → blocking1.8.1.7+

Comment 5

11 years ago
Created attachment 280724 [details] [diff] [review]
Patch to replace update.mozilla.org with addons.mozilla.org
Attachment #279487 - Attachment is obsolete: true
Attachment #280724 - Flags: approval1.8.1.7?

Comment 6

11 years ago
Patch updated. requested approval

Comment 7

11 years ago
Comment on attachment 280724 [details] [diff] [review]
Patch to replace update.mozilla.org with addons.mozilla.org

>Index: extensions.properties
>+extensions.getMorePluginsURL=https://%LOCALE%.add-ons.mozilla.com/%LOCALE%/%APP%/%VERSION%/plugins/

Please don't add extensions.getMorePluginsURL, that's only used on the trunk, but not on the branch.

With that fixed, a=me for landing on the branch. Please use the fixed1.8.1.7 and verified1.8.1.7 keywords to track landing and testing, resp.
Attachment #280724 - Flags: approval1.8.1.7? → approval1.8.1.7+

Comment 8

11 years ago
Removed extensions.getMorePluginsURL, added to cvs, added keywords.
Keywords: fixed1.8.1.7, verified1.8.1.7

Updated

11 years ago
Keywords: verified1.8.1.7
(Reporter)

Comment 9

11 years ago
verified fixed on Windows and Mac. The Code is fixed now.

Adding verified keyword.
Status: NEW → RESOLVED
Last Resolved: 11 years ago
Keywords: fixed1.8.1.8 → verified1.8.1.7
Resolution: --- → FIXED
1.8.1.7 is a firedrill coming off a side branch. Stuff landed on the 1.8 branch will end up in 1.8.1.8
Keywords: verified1.8.1.7 → verified1.8.1.8
No longer blocks: 585947
You need to log in before you can comment on or make changes to this bug.