394650 - Make line numbers linkable when viewing files/annotate for hg.mozilla.org

Status: RESOLVED FIXED

(mozilla.org Graveyard :: Server Operations: Projects, task)

Description

[Ed Lee :Mardak]

Attachment: v1

For "file" view on mercurial gitweb, has line numbers but they aren't links like on mxr. For "annotate" view, there are no line numbers at all.

Each line gets an anchor with id "l<num>" that links it itself.

Perhaps this should get pushed upstream?

Comment 1

[Ed Lee :Mardak]

Attachment: v2

Updated the patch to change the default template as well, so it's more likely to land upstream. So if that happens, this bug would be to grab those changes and run a crew/crew-stable version of mercurial on hg.mo.. ?

----

Add line anchors to file and annotate views for hgweb
http://www.selenic.com/pipermail/mercurial/2007-September/014491.html

This patch makes the line numbers into anchor tags with id "l<num>"
(e.g., l123) that link to itself with href=#l<num>. Updates default
and gitweb templates.

hgweb's ability to show the whole repository for any given changeset
is really useful, but referring to a particular line of a file such as
from a bug report would be nice. The patch adds a couple new
template-vars such as lineid and linenumber. Also, the annotate pages
didn't have line numbers to begin with, so there's a column for that
now.

Comment 2

[Aravind Gottipati [:aravind]]

I do not want to maintain our own copy of mercurial builds, but would rather depend on this being present in the upstream builds.  I can change templates and such to customize the look, etc, but I'd rather not modify code that ships as a part of the app.

Could you please work with upstream devs to get this path there?

Comment 3

[Ed Lee :Mardak]

I've submitted a patch to the mercurial-devel list

http://selenic.com/pipermail/mercurial-devel/2007-September/002806.html

It adds a couple new template vars for use on annotate, changeset, diff, file views. The patch also includes the changes for the map files themselves, but if those don't make it in upstream, we can apply those template changes ourselves.

Comment 4

[Aravind Gottipati [:aravind]]

Moving this to projects since I will work on this next quarter.

Comment 5

[Adam Guthrie]

Fixed upstream (http://www.selenic.com/mercurial/bts/issue506) and currently working great on hg.mozilla.org!

(Should be FIXED UPSTREAM, but I guess WORKSFORME is good enough.)

Comment 6

[Ed Lee :Mardak]

Actually, I was trying to figure out how it got fixed and noticed that it seemed to be implemented exactly how I implemented it..

http://www.selenic.com/pipermail/mercurial/2007-September/014513.html

I sent in a patch some time ago back in September but never kept up to see if it ever got on. ;)

Apparently it did and made it for Mercurial 1.0. :)

http://hg.intevation.org/mercurial/crew/rev/800e2756c9ab