394763 - Canvas drawWindow should also draw caret if visible

Status: RESOLVED DUPLICATE of bug 458373

(Core :: Graphics: Canvas2D, defect, P4)

Description

[Martijn Wargers (dead)]

Attachment: testcase

See (clumsy) testcase. The testcase needs enhanced privileges, so you need to download it to your computer.
The caret isn't drawn with the canvas drawWindow method.
I think it would be useful and make sense to draw the caret too.
In that case, reftests would be possible for bugs like bug 394473.

Comment 1

[Joe Drew (not getting mail)]

I'm not 100% sure, but I defintely see a line that easily could be a caret on OS X. Martijn, can you re-verify on current trunk? (I don't have an XP box to test with.)

Comment 2

[Martijn Wargers (dead)]

Yeah, this was fixed for some time now, but I didn't bother looking and closing the bug I filed (lazy me).

Comment 3

[Robert O'Callahan (:roc) (email my personal email if necessary)]

This was unintentional ... but OK

Comment 4

[Martijn Wargers (dead)]

Attachment: testcase

Argh, this isn't working yet. The previous testcase was probably painting a line from the canvas border, that's why it appeared to be working.

This is a better testcase, that shows this still isn't working.

Comment 6

[:Gavin Sharp [email: [e-mail]]]

Bug 458373 is a fennec specific bug about adding a flag to control this behavior. If you want it in general then I guess that would be unnecessary...

Comment 7

[Martijn Wargers (dead)]

Yes, that would be unnecessary.