394963 - change master.cfg to use ShellCommand("cvs"...), not CVS step

Status: RESOLVED FIXED

(Release Engineering :: General, defect, P3)

Description

[John O'Duinn [:joduinn] (please use "needinfo?" flag)]

As a workaround for unresolved issues about passing branch names from buildbot to cvs, try the following:

Replace the use of CVS "step" syntax:
...
tagFactory.addStep(CVS, cvsroot=cvsroot, branch=None, cvsmodule=cvsmodule, 
                   mode="clobber")
...
with what we had originally, which was calling CVS using ShellCommand("cvs"...). 

This will help ensure we always use the proper bootstrap tag, and help us avoid dealing with Buildbot's idea of branches, sourcestamps, etc.

Comment 1

[Robert Helmer [:rhelmer]]

Attachment: call cvs from ShellCommand

Already landed and testing, please take a look. If this works ok, we need to merge into the production master.cfg

Comment 2

[Robert Helmer [:rhelmer]]

Attachment: call cvs from ShellCommand, merged into production config

Here's the production version. Note that "automation_tag" is set to the latest Bootstrap tag, we'll need to bump that when we do a new Bootstrap tag.

Also, I corrected "projectName" at the bottom to say "Production" not "Test".

Comment 3

[John O'Duinn [:joduinn] (please use "needinfo?" flag)]

Comment on attachment 283269 [details] [diff] [review]
call cvs from ShellCommand

I like the change from "branch" to "automation_tag"... much less confusing.

Comment 4

[John O'Duinn [:joduinn] (please use "needinfo?" flag)]

Comment on attachment 283285 [details] [diff] [review]
call cvs from ShellCommand, merged into production config

1) Again, agree with "automation_tag" instead of branch, its less confusing.

2) Thanks for catching the projectName typo.