395017 - Event & Task dialog for read-only calendars don't show start time and end/due date and time

Status: VERIFIED FIXED

(Calendar :: Calendar Frontend, defect)

Description

[Stefan Sitter [:ssitter]]

Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8.1.7pre) Gecko/20070904 Calendar/0.7pre

Steps to Reproduce:
1a. Create non-repeating event
1b. Create non-repeating all-day event
1c. Create non-repeating event that spans multiple days
1d. Create non-repeating task with/without start and or due date
2.  Open calendar properties dialog and mark calendar as Read-only
3.  Open the Event/Task dialog for the events/tasks created before

Actual Results:
The dialog only shows the date the event/task starts on. 
The dialog doesn't show information about the start time and the end/due date/time or if this is an all-day event. It's not possible to distinguish the events from 1a, 1b, 1c or 1d from looking at this dialog.

Expected Results:
The dialog should include start time and the end/due date/time or if this is an all-day event.

Comment 1

[Stefan Sitter [:ssitter]]

Either this should be fixed to allow proper usage of read-only calendars within Sunbird/Lightning or this dialog should be removed and the normal event dialog should be extended to handle read-only events. I'd prefer the 2nd solution to avoid code duplication.

Comment 2

[Berend Cornelius]

Attachment: patch v. #1

I fixed this isse also for the task-datail-view where we have a similar summary display. In the long run I think it makes sense to consolidate these two implementations. Andreas tested this patch beforehand.

Comment 3

[Philipp Kewisch [:Fallen] [:📆][:🧩]]

Comment on attachment 325243 [details] [diff] [review]
patch v. #1

>+        document.getElementById("item-datetime-start")
>+            .value = formatter.formatDateTime(
Please align the dots.

>+    if ((!end) || (end.isDate == true)) {
Remove extra () around both expressions


r=philipp

Comment 4

[Berend Cornelius]

checked in patch with philipp's comments worked in on trunk and MOZILLA_1_8_BRANCH
->FIXED

Comment 5

[Andreas Treumann]

Checked in lightning build 2008061618 and Sunbird 20080616 -> VERIFIED.