Last Comment Bug 395080 - Double backslash in sysDir filenames causes problems on OS/2
: Double backslash in sysDir filenames causes problems on OS/2
Status: RESOLVED FIXED
:
Product: NSS
Classification: Components
Component: Libraries (show other bugs)
: unspecified
: x86 OS/2
: P3 trivial (vote)
: 3.12
Assigned To: Peter Weilbacher
:
:
Mentors:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2007-09-05 14:36 PDT by Peter Weilbacher
Modified: 2007-09-13 02:17 PDT (History)
2 users (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---


Attachments
remove double backslash (1.05 KB, patch)
2007-09-05 14:36 PDT, Peter Weilbacher
julien.pierre: review+
Details | Diff | Splinter Review

Description Peter Weilbacher 2007-09-05 14:36:18 PDT
Created attachment 279795 [details] [diff] [review]
remove double backslash

While debugging another bug I found that in EnumSystemFiles() in os2_rand.c the filename that gets passed to (*func) contains a double backslash. sysDir has a trailing backslash and the sprintf adds another one. While this doesn't cause any immediate problems I think this should be cleaned up (OS/2 APIs like DosOpen don't like double backslashes).
Comment 1 Peter Weilbacher 2007-09-09 03:32:44 PDT
I need someone with NSS checkin powers to get this into the tree.
Comment 2 Julien Pierre 2007-09-11 15:20:05 PDT
Peter,

I checked this in to the trunk.

Checking in os2_rand.c;
/cvsroot/mozilla/security/nss/lib/freebl/os2_rand.c,v  <--  os2_rand.c
new revision: 1.6; previous revision: 1.5
done

Note You need to log in before you can comment on or make changes to this bug.