Double backslash in sysDir filenames causes problems on OS/2

RESOLVED FIXED in 3.12

Status

NSS
Libraries
P3
trivial
RESOLVED FIXED
10 years ago
10 years ago

People

(Reporter: Peter Weilbacher, Assigned: Peter Weilbacher)

Tracking

unspecified
3.12
x86
OS/2

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

10 years ago
Created attachment 279795 [details] [diff] [review]
remove double backslash

While debugging another bug I found that in EnumSystemFiles() in os2_rand.c the filename that gets passed to (*func) contains a double backslash. sysDir has a trailing backslash and the sprintf adds another one. While this doesn't cause any immediate problems I think this should be cleaned up (OS/2 APIs like DosOpen don't like double backslashes).
Attachment #279795 - Flags: review?(julien.pierre.boogz)

Updated

10 years ago
Attachment #279795 - Flags: review?(julien.pierre.boogz) → review+
(Assignee)

Comment 1

10 years ago
I need someone with NSS checkin powers to get this into the tree.
Keywords: checkin-needed
Assignee: nobody → julien.pierre.boogz
Assignee: julien.pierre.boogz → mozilla

Comment 2

10 years ago
Peter,

I checked this in to the trunk.

Checking in os2_rand.c;
/cvsroot/mozilla/security/nss/lib/freebl/os2_rand.c,v  <--  os2_rand.c
new revision: 1.6; previous revision: 1.5
done
Status: NEW → RESOLVED
Last Resolved: 10 years ago
Priority: -- → P3
Resolution: --- → FIXED
Summary: Double backslash in sysDir filenames → Double backslash in sysDir filenames causes problems on OS/2
Target Milestone: --- → 3.12
(Assignee)

Updated

10 years ago
Keywords: checkin-needed
You need to log in before you can comment on or make changes to this bug.