Closed Bug 395099 Opened 17 years ago Closed 17 years ago

src attribute doesn't work in statusbarpanel object, regression in FFx3

Categories

(Toolkit :: UI Widgets, defect)

x86
Windows XP
defect
Not set
normal

Tracking

()

RESOLVED FIXED

People

(Reporter: bhsieh, Assigned: enndeakin)

References

Details

(Keywords: regression)

Attachments

(2 files, 1 obsolete file)

This is a regression in FFx3, doesn't happen in 2.0.0.6

The image displays correctly if you use

> style="list-style-image: url('chrome://qa/content/qmo-16px.png')"

but not if you use
> src="chrome://qa/content/qmo-16px.png"

Both the style and the src work in 2.0.0.6. Testcase attached, unzip into your extension directory.
Summary: src attribute doesn't work in statusbarpanel object → src attribute doesn't work in statusbarpanel object, regression in FFx3
Flags: blocking1.9?
Attached file testcase (obsolete) —
Er, actually attached zip this time. Comment out one of the two <statusbarpanel> lines in browserOverlays.xul to see src vs. style functionality.
Neither 
<statusbarpanel class="statusbarpanel-iconic" src="chrome://browser/skin/Toolbar.png"/> nor 
<statusbarpanel class="statusbarpanel-iconic" image="chrome://browser/skin/Toolbar.png"/> seem to work in a current trunk build. Changing the inherits at http://bonsai.mozilla.org/cvsblame.cgi?file=mozilla/toolkit/content/widgets/general.xml&rev=1.20&mark=283#283 back to just "src" fixes it, which points to bug 377696.
Component: XP Toolkit/Widgets: XUL → XUL Widgets
Product: Core → Toolkit
QA Contact: xptoolkit.xul → xul.widgets
Version: unspecified → Trunk
Attached file simplified testcase
Attachment #279818 - Attachment is obsolete: true
Attached patch fixSplinter Review
Didn't seem to have much luck with bug 377696 :(
Assignee: nobody → enndeakin
Status: NEW → ASSIGNED
Attachment #279895 - Flags: review?(mano)
Keywords: regression
Comment on attachment 279895 [details] [diff] [review]
fix

should have caught that, ugh.
Attachment #279895 - Flags: review?(mano) → review+
Attachment #279895 - Flags: approval1.9?
Comment on attachment 279895 [details] [diff] [review]
fix

a=bzbarsky
Attachment #279895 - Flags: approval1.9? → approval1.9+
Status: ASSIGNED → RESOLVED
Closed: 17 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: