Closed
Bug 395136
Opened 17 years ago
Closed 17 years ago
show types handled only by disabled plugins in Applications prefpane
Categories
(Firefox :: File Handling, defect, P2)
Firefox
File Handling
Tracking
()
RESOLVED
FIXED
Firefox 3 beta1
People
(Reporter: myk, Assigned: myk)
References
Details
Attachments
(1 file)
1.28 KB,
patch
|
Gavin
:
review+
mconnor
:
approval1.9+
|
Details | Diff | Splinter Review |
We should show types handled only by disabled plugins in the Applications prefpane in order to give users the chance to reenable the plugins (or choose an application to deal with that type).
Assignee | ||
Updated•17 years ago
|
Assignee: nobody → myk
Priority: -- → P2
Target Milestone: --- → Firefox 3 M9
Assignee | ||
Comment 1•17 years ago
|
||
This depends on bug 395138, because if only a disabled plugin handles a type, then we're going to ask the user what to do when she hits some content of that type, and we need to be able to say that in the prefpane if we're going to show these types in that pane. I'll note, however, that the only way a user will normally disable a plugin is by selecting an application to handle the type in the Applications prefpane, and if they do that, then we register that handler as a possible handler for the type, which means that there's another handler for the type besides the plugin, and the question of what to do with a type handled only by a disabled plugin is moot. Which is a long way of saying that users will not be encountering this situation very often (they can still encounter it if the application that handles the type gets uninstalled or if the user manually twiddles the plugin.disable_full_page_plugin_for_type preference) and thus it's not very important to fix this.
Severity: normal → minor
Depends on: 395138
Assignee | ||
Comment 2•17 years ago
|
||
Requesting wanted-1.9 for this Applications prefpane polish fix.
Flags: blocking-firefox3?
Updated•17 years ago
|
Flags: blocking-firefox3? → blocking-firefox3-
Whiteboard: [wanted-firefox3]
Assignee | ||
Comment 3•17 years ago
|
||
This simple patch shows types handled only by disabled plugins. Note that such types will display an incorrect action until bug 398626 is fixed.
Attachment #283639 -
Flags: review?(gavin.sharp)
Updated•17 years ago
|
Attachment #283639 -
Flags: review?(gavin.sharp) → review+
Assignee | ||
Comment 4•17 years ago
|
||
Comment on attachment 283639 [details] [diff] [review] patch v1: shows types Requesting approval to check in this small, low-risk fix for a wanted-firefox3 bug.
Attachment #283639 -
Flags: approval1.9?
Updated•17 years ago
|
Attachment #283639 -
Flags: approval1.9? → approval1.9+
Assignee | ||
Comment 5•17 years ago
|
||
Checking in browser/components/preferences/applications.js; /cvsroot/mozilla/browser/components/preferences/applications.js,v <-- applications.js new revision: 1.20; previous revision: 1.19 done
Status: NEW → RESOLVED
Closed: 17 years ago
Resolution: --- → FIXED
Updated•17 years ago
|
Flags: wanted-firefox3+
Whiteboard: [wanted-firefox3]
You need to log in
before you can comment on or make changes to this bug.
Description
•