395136 - show types handled only by disabled plugins in Applications prefpane

Status: RESOLVED FIXED

(Firefox :: File Handling, defect, P2)

Description

[Myk Melez [:myk] [@mykmelez]]

We should show types handled only by disabled plugins in the Applications prefpane in order to give users the chance to reenable the plugins (or choose an application to deal with that type).

Comment 1

[Myk Melez [:myk] [@mykmelez]]

This depends on bug 395138, because if only a disabled plugin handles a type, then we're going to ask the user what to do when she hits some content of that type, and we need to be able to say that in the prefpane if we're going to show these types in that pane.

I'll note, however, that the only way a user will normally disable a plugin is by selecting an application to handle the type in the Applications prefpane, and if they do that, then we register that handler as a possible handler for the type, which means that there's another handler for the type besides the plugin, and the question of what to do with a type handled only by a disabled plugin is moot.

Which is a long way of saying that users will not be encountering this situation very often (they can still encounter it if the application that handles the type gets uninstalled or if the user manually twiddles the plugin.disable_full_page_plugin_for_type preference) and thus it's not very important to fix this.

Comment 2

[Myk Melez [:myk] [@mykmelez]]

Requesting wanted-1.9 for this Applications prefpane polish fix.

Comment 3

[Myk Melez [:myk] [@mykmelez]]

Attachment: patch v1: shows types

This simple patch shows types handled only by disabled plugins.  Note that such types will display an incorrect action until bug 398626 is fixed.

Comment 4

[Myk Melez [:myk] [@mykmelez]]

Comment on attachment 283639 [details] [diff] [review]
patch v1: shows types

Requesting approval to check in this small, low-risk fix for a wanted-firefox3 bug.

Comment 5

[Myk Melez [:myk] [@mykmelez]]

Checking in browser/components/preferences/applications.js;
/cvsroot/mozilla/browser/components/preferences/applications.js,v  <--  applications.js
new revision: 1.20; previous revision: 1.19
done