Closed
Bug 395139
Opened 17 years ago
Closed 17 years ago
only filter on displayed values in Applications prefpane
Categories
(Firefox :: File Handling, defect, P2)
Firefox
File Handling
Tracking
()
RESOLVED
FIXED
Firefox 3 beta1
People
(Reporter: myk, Assigned: myk)
References
Details
Attachments
(1 file)
|
1.25 KB,
patch
|
Gavin
:
review+
mconnor
:
approval1.9+
|
Details | Diff | Splinter Review |
The new Applications prefpane lets you filter its list, but the filter searches not only the two values you can see (type name, action name) but also two values you cannot see (MIME type, if any, and file extension, if any).
We should only filter on visible information, otherwise we will confuse users who get inexplicable results in their filtered set.
|
Assignee | |
Updated•17 years ago
|
Assignee: nobody → myk
Priority: -- → P2
Target Milestone: --- → Firefox 3 M9
|
|
Assignee | |
Comment 1•17 years ago
|
||
Attachment #280816 -
Flags: review?(gavin.sharp)
|
||
Updated•17 years ago
|
Attachment #280816 -
Flags: review?(gavin.sharp) → review+
|
|
Assignee | |
Comment 2•17 years ago
|
||
Comment on attachment 280816 [details] [diff] [review]
patch v1: filters only on displayed values
Requesting approval to land this in M9. This is a simple, low-risk patch that eliminates an edge case where a user might filter the list of content types and see something on the list that doesn't match her filter.
Attachment #280816 -
Flags: approval1.9?
|
||
Updated•17 years ago
|
Attachment #280816 -
Flags: approval1.9? → approval1.9+
|
|
Assignee | |
Comment 3•17 years ago
|
||
Checking in browser/components/preferences/applications.js;
/cvsroot/mozilla/browser/components/preferences/applications.js,v <-- applications.js
new revision: 1.2; previous revision: 1.1
done
Status: NEW → RESOLVED
Closed: 17 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•