395155 - Changing CSS text inside <svg:style> has no effect

Status: RESOLVED FIXED

(Core :: SVG, defect)

Description

[Jesse Ruderman]

Attachment: testcase 2

Changing the CSS text inside <svg:style> fails to update the document's rendering.

Comment 1

[Robert Longson [:longsonr]]

c.f. bug 367612 and bug 383137

Comment 2

[Robert Longson [:longsonr]]

Attachment: patch

Comment 3

[Robert O'Callahan (:roc) (email my personal email if necessary)]

+  if (nsContentUtils::IsInSameAnonymousTree(this, aContent)) {
+    UpdateStyleSheetInternal(nsnull);
+  }

This is just an optimization, right? Why do you think it's worth having?

Comment 4

[Robert Longson [:longsonr]]

It comes from bug 383137. I don't know if you can do the same in SVG but it seemed  safer just to do the same thing too just in case.

Comment 5

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Ugh, that is not M8 approval, just general approval, so don't check in until the freeze is over.

Comment 6

[Robert Longson [:longsonr]]

checked in.

Comment 7

[Robert Longson [:longsonr]]

Checked in reftests:
http://lxr.mozilla.org/seamonkey/source/layout/reftests/svg/text-style-01a.svg
http://lxr.mozilla.org/seamonkey/source/layout/reftests/svg/text-style-01b.svg
http://lxr.mozilla.org/seamonkey/source/layout/reftests/svg/text-style-01c.svg
http://lxr.mozilla.org/seamonkey/source/layout/reftests/svg/text-style-01d.svg
http://lxr.mozilla.org/seamonkey/source/layout/reftests/svg/text-style-01e.svg