switch nsSessionStartup to XPCOMUtils

RESOLVED FIXED

Status

()

Firefox
Session Restore
RESOLVED FIXED
11 years ago
11 years ago

People

(Reporter: Robert Sayre, Assigned: Robert Sayre)

Tracking

Trunk
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

11 years ago
It will be smaller this way.
(Assignee)

Comment 1

11 years ago
Created attachment 279946 [details] [diff] [review]
use XPCOMUtils
Attachment #279946 - Flags: review?(dietrich)
OS: SunOS → All
Hardware: PC → All
Comment on attachment 279946 [details] [diff] [review]
use XPCOMUtils

thanks, r=me
Attachment #279946 - Flags: review?(dietrich) → review+

Comment 3

11 years ago
Comment on attachment 279946 [details] [diff] [review]
use XPCOMUtils

Nit:
> +    // make BrowserGlue a startup observer

Copy&paste oversight: this is SessionStartup, not BrowserGlue. Otherwise this looks like some nice savings. r+ with nit fixed.

Mind to do nsSessionStore.js as well?
(Assignee)

Updated

11 years ago
Attachment #279946 - Flags: approval1.9?
(Assignee)

Comment 4

11 years ago
(In reply to comment #3)
> (From update of attachment 279946 [details] [diff] [review])
> Nit:
> > +    // make BrowserGlue a startup observer

Whoops, I'll fix that comment before checking in. Ryan Flint is converting nsSessionStore.js

Updated

11 years ago
Attachment #279946 - Flags: approval1.9? → approval1.9+
Assignee: nobody → sayrer
Version: unspecified → Trunk
(Assignee)

Updated

11 years ago
Status: NEW → RESOLVED
Last Resolved: 11 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.