395437 - 'Dismiss All' doesn't dismiss all alarms (skips every second)

Status: VERIFIED FIXED

(Calendar :: Alarms, defect)

Description

[Stefan Sitter [:ssitter]]

Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.8.1.7pre) Gecko/20070907 Calendar/0.7pre

'Dismiss All' doesn't dismiss all alarms (skips every second)

Steps to Reproduce:
1. Create four events with alarms set (e.g. event '1', '2', '3' and '4')
2. Wait until all four alarms are fired and press 'Dismiss All'
3. Restart Sunbird

Actual Results:
Alarm popup for event '2' and '4' are displayed.

Expected Results:
No alarm popup because all alarms were dismissed.

Same error was fixed with Bug 353051 for Sunbird 0.3 but was regressed by the checkin for Bug 389245.

Comment 1

[Stefan Sitter [:ssitter]]

Attachment: rev0 - loop in reverse order

Comment 2

[Daniel Boelzle [:dbo]]

Comment on attachment 280113 [details] [diff] [review]
rev0 - loop in reverse order

good catch, thanks for the patch; r=dbo

Comment 3

[Daniel Boelzle [:dbo]]

Checked in on HEAD and MOZILLA_1_8_BRANCH.

Comment 4

[Damian Szczepanik]

verified with
Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8.1.7pre) Gecko/20070908 Calendar/0.7pre

Comment 5

[Stefan Sitter [:ssitter]]

Litmus Testcase 2695 was created for this, see Bug 353051 Comment #11.