395620 - Omnibus ad-blocking bug for September 2007

Status: RESOLVED FIXED

(Camino Graveyard :: Annoyance Blocking, defect)

Description

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

Comment 1

[Chris Lawson (gone)]

I keep getting one random banner ad on various articles on freep.com. It's not every article and it's not every time I reload, but it happens just often enough to be annoying.

URL for the ad is usually something like:

http://gcirm.dmp.gcion.com/RealMedia/ads/click_lx .ads/www.freep.com/voices/columnists/2012718239/7 28x90_1/OasDefault/freep-circ-dunkin-0507-ROS/728 x90dunkin-freep.html/3432623033623738343665316434 6630?http://www.dunkindonuts.com

I think we can safely block all of

gcirm.dmp.gcion.com

without risk, but I'd be interested in knowing why our existing rules aren't catching the /RealMedia/ or /ads/ portions of this URL, and if there's anything we can tweak to fix that.

cl

Comment 2

[sairuh (rarely reading bugmail)]

I've seen Flash ads on Yahoo Groups pages from richmedia.yimg.com --for example:

http://richmedia.yimg.com/customer/06/6/ob.d/FF07c_728x90p3.swf?adxq=1188597072
http://richmedia.yimg.com/customer/06/6/transparent_728x90.swf?adxq=1188597048

Comment 3

[sairuh (rarely reading bugmail)]

Correction: the ads seem to come from richmedia*.yimg.com, eg,

http://richmedia2.yimg.com/customer/06/6/YoPlus_Base728_final.swf?adxq=1189031889

To test, load http://groups.yahoo.com/group/girlgenius/messages --you might need to click on one of the message topic links to see the Flash banner ad at the top of the page.

Comment 4

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

On http://wingsofsorrow.deviantart.com/art/camino-icon-58443154

div id="google_ads_div_bottom_lb_deviations_customization"
iframe id="google_ads_iframe_bottom_lb_deviations_customization"

Comment 5

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

On http://www18.mappy.com/sid2u76+fLfJ9PMn21w/cFGM?recherche=0&posl=poi&show_poi=0&show_iti=0&poix=0&poiy=0&poi_rr=0.5&poi_rx=0.6&poi_ry=0.5&csl=poi&fsl=m2&gsl=m2&msl=m2&temp_no_prop=0&comment=&xsl=plan&out=2&lr=0.5&wcm2=&nom2=&tcm2=&a10m2=&xm2=&ym2=&wnm2=3+rue+Monge&tnm2=Paris&pcm2=75005&scm2=&ccm2=250&com2=EU&x=35&y=9

<DIV id="mTotem">

  <IFRAME width="148" scrolling="no" height="0" frameborder="0"
          src="/fwd/xsl/?templ=mappy_v2/pub/totem&amp;domaine=www.mappy.fr&amp;departement=075&amp;page=map&amp;localite=05600&amp;RNS=3810000125&amp;tc=75056"
          id="totem" style="height: 300px;"/>

</DIV>

I'm not sure how common "totem" is as an id, but we can do a combination selector using both that should be pretty safe.

Also, some Flash with url beginning http://cstatic.weborama.fr/weborama/adperf/

Comment 6

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

Attachment: Sept Omnibus Ad-Blocking

Fixes the ads mentioned here and in bug 396905.

Also, observed in the process: <div id="ad-blocking-makes-fella-sad"> ;)

Comment 7

[Simon Fraser [no longer active]]

Comment on attachment 282966 [details] [diff] [review]
Sept Omnibus Ad-Blocking

The ids spR336 and spM420 are too site-specific. Can we get a way with just the spCommercial class?

Comment 8

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

I was afraid that "spCommercial" might be too generic.  

philippe, those are your rules from bug 396905 (well, the second one I added to block a second ad block on that page); what do you think?

Comment 9

[philippe (part-time)]

spCommercial alone is definitely too generic

iframe[src*="werben-mit-campus-media.de/ads/"] {display:none !important;}
also blocks those
werben-mit-campus-media.de redirects to http://www.campusmedia.de/ which is a media marketing company. I suspect it is their ad server.

I've never seen those ads except on spiegel.de btw, but I don't surf that much around Germany.

Comment 10

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

Simon, is philippe's new rule in comment 9 OK with you?

Comment 11

[Simon Fraser [no longer active]]

Yes

Comment 12

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

Attachment: Sept Omnibus Ad-Blocking with comment 9's rule

New patch with the comment 7 et seq. change.

Comment 13

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

Checked in on the 18branch and trunk.

Comment 14

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

Landed on the CAMINO_1_5_BRANCH for 1.5.4.