395661 - XULRunner restart fails if path to application.ini is relative

Status: RESOLVED WORKSFORME

(Toolkit Graveyard :: XULRunner, defect)

Description

[Wladimir Palant]

I start a XULRunner application:

xulrunner/xulrunner.exe xul/application.ini

Somewhere in the application a restart is triggered:

    Components.classes["@mozilla.org/toolkit/app-startup;1"].getService(nsIAppStartup)
              .quit(nsIAppStartup.eAttemptQuit | nsIAppStartup.eRestart);

On restart I see the message "Error: couldn't parse application.ini". Reason is that the current directory changed, relative application.ini path is resolved to xulrunner/xul/application.ini.

I see two possible solutions:

1. Don't store relative paths, save the path after resolution of relative paths instead.

2. Save current directory and restore is when application is restarted.

The first should be easier to implement while the second is a more general solution for this kind of issues.

Comment 1

[Wladimir Palant]

Attachment: Proposed patch

This patch implements the first alternative. Please tell me if you think that we need a more general approach here.

Comment 2

[Mark Finkle (:mfinkle) (use needinfo?)]

For consistency, should the absolute path code be added here too?
http://mxr.mozilla.org/seamonkey/source/browser/app/nsBrowserApp.cpp#139

Comment 3

[Wladimir Palant]

Attachment: Proposed patch v2

You are right, we need to change browser as well.

Comment 4

[Mark Finkle (:mfinkle) (use needinfo?)]

FYI: the potential fix for bug 386826 will collide with this patch

Comment 5

[Wladimir Palant]

Yes, I am aware of that.

Comment 6

[Wladimir Palant]

Comment on attachment 280339 [details] [diff] [review]
Proposed patch v2

According to Roland Boon, his patch in bug 386826 fixes this issue as well.