Closed
Bug 395678
Opened 17 years ago
Closed 17 years ago
Fix const issues with strchr in C++
Categories
(Core :: JavaScript Engine, defect)
Tracking
()
RESOLVED
FIXED
People
(Reporter: benjamin, Assigned: benjamin)
Details
Attachments
(1 file)
|
779 bytes,
patch
|
mrbkap
:
review+
brendan
:
approval1.9+
|
Details | Diff | Splinter Review |
With MSVC, strchr returns a "const char*"... and when compiling spidermonkey in C++, you would have to explicitly cast away the const to assign the result to a char*. But that's not necessary, because the two instances we have currently we can just make the relevant local a const char*.
Attachment #280348 -
Flags: review?(mrbkap)
|
||
Updated•17 years ago
|
Attachment #280348 -
Flags: review?(mrbkap) → review+
|
Assignee | |
Updated•17 years ago
|
Attachment #280348 -
Flags: approval1.9?
|
||
Comment 1•17 years ago
|
||
Comment on attachment 280348 [details] [diff] [review] Fix mozilla-central on Windows, rev. 1 a=me. /be
Attachment #280348 -
Flags: approval1.9? → approval1.9+
|
|
Assignee | |
Comment 2•17 years ago
|
||
Fixed on CVS trunk
Status: NEW → RESOLVED
Closed: 17 years ago
Resolution: --- → FIXED
|
||
Updated•17 years ago
|
Flags: in-testsuite-
You need to log in
before you can comment on or make changes to this bug.
Description
•