Closed Bug 395689 Opened 13 years ago Closed 13 years ago

XML pretty print leaks

Categories

(Core :: XSLT, defect)

x86
macOS
defect
Not set

Tracking

()

RESOLVED FIXED

People

(Reporter: sayrer, Assigned: peterv)

References

()

Details

(Keywords: memory-leak)

Attachments

(1 file)

The document in the URL is just an example, I think all of them leak.


                                                                                 
     |<----------------Class--------------->|<-----Bytes------>|<----------------
                                              Per-Inst   Leaked    Total      Rem
   0 TOTAL                                          28      288   194656       64
nsTraceRefcntImpl::DumpStatistics: 675 entries                                   
  29 Expr                                            4       76       83       19
 516 nsStringBuffer                                  8       16    22116        2
 533 nsTArray_base                                   4       76     3695       19
 582 nsVoidArray                                     4        4     8094        1
 661 txAExprResult                                  12       36      276        3
 664 txNodeTest                                      4       80       43       20
Blocks: 394517
Keywords: mlk
Does this still leak now that bug 393329 and bug 397386 are fixed?
It probably does, yes. I'm still working on figuring out the root leak.
Assignee: nobody → peterv
Attached patch v1Splinter Review
Doh. I've also gone through all base classes in content/xslt to make sure they all had a virtual destructor, txPattern was the last one.
Attachment #283407 - Flags: superreview?(jonas)
Attachment #283407 - Flags: review?(jonas)
Attachment #283407 - Flags: approval1.9?
Attachment #283407 - Flags: superreview?(jonas)
Attachment #283407 - Flags: superreview+
Attachment #283407 - Flags: review?(jonas)
Attachment #283407 - Flags: review+
Attachment #283407 - Flags: approval1.9?
Attachment #283407 - Flags: approval1.9+
Thanks!
Status: NEW → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Flags: in-testsuite?
You need to log in before you can comment on or make changes to this bug.