Closed Bug 39576 Opened 20 years ago Closed 20 years ago
localisable text in messenger/addressbook xul and js files
There is still localisable content within the following xul and js files : FilterListDialog.xul (chrome/messenger...) importProgress.xul(chrome/messenger...) SearchDialog.xul(chrome/messenger...) abCardOverlay.js (chrome/addressbook...) addressbook.js (chrome/addressbook...) abCardViewOverlay.js (chrome/addressbook...)
adding in keyword
nsbeta2+ for Search Dialog and Address book only. Minus for the other files.
Laura, can you describe them in detail? which strings?
Reassigned to danm.
Assignee: rchen → danm
Component: Localization → Address Book
Summary: localisable text in xul and js files → localisable text in messenger/addressbook xul and js files
urk!@@? Reassigning to, oh, I know, the person cvsblame fingered as the author of the first offending line I could find in the file list given. importProgress.xul, line 43. PS: I skipped FilterListDialog.xul, which looked clean to me.
Assignee: danm → tonyr
SOme of these files are longer applicable, so I will just detail the ones that are - I based these on build 2000-06-05-09-M16 importProgress.xul <text id="progressTitle" value="Title"/> <text id="progressStatus" value="Processing" flex="1"/> addressboook.js cvPrefs.titlePrefix = "Card for "; (appears when you have a card created for a person and you select that persons name in your address list and their details appear below)
I'm making this bug public so tony can see this. Is there a reason why it's not? I don't see anything in the bug that would cause that.
Is the problem related to addressboook.js cvPrefs.titlePrefix = "Card for "; really tony's bug? alecf recently fixed a very similar bug and probably this should be part of that fix: http://bugzilla.mozilla.org/show_bug.cgi?id=28993
I've fixed the addressbook stuff like Card for Tony is only responsible for import stuff.
alec, the fix in Bug 28993 does not fix the problem of cvPrefs.titlePrefix = "Card for "; I translated "editCardTitle = Card for" into Japanese but that has no effect in the viewing pane display. Should I file a separate bug for this?
Alec, I have a bug specifically for this (#39004). I'll go ahead and fix that one (it's also nsbeta2+). I don't know if you've got the rest of this one done so I'm sending it back to you to mark fixed if so.
Assignee: tonyr → alecf
oops, I thought today was the 10th
Whiteboard: [nsbeta2+] ETA: 7/11 → [nsbeta2+] ETA: 7/12
Whiteboard: [nsbeta2+] ETA: 7/12 → [nsbeta2+] ETA: 7/12 Fix in hand
scott or candice, can you review the patch I attached? Then I can check it in today before this gets axed :)
It looks fine to me, go ahead to check in.
fix is in for the "Card for" thing - I think that's the only one left! To QA: this affects the "Card for XXX" in the "results pane" in the address book.
argh, actually mark it fixed this time
Status: ASSIGNED → RESOLVED
Closed: 20 years ago
Resolution: --- → FIXED
** Checked with 8/2/2000 Win32 M17 build with a JPN Lg Pack ** The remaining porblem was the string "Card for .." as it appears in the result view pane of the Address Book window. We can now see translated data for this string. Marking the fix verified as fixed.
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.