395940 - [Proto] Event Dialog: Save Changes? dialog should use descriptive button labels

Status: VERIFIED FIXED

(Calendar :: General, enhancement)

Description

[Stefan Sitter [:ssitter]]

Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.8.1.7pre) Gecko/20070912 Calendar/0.7pre

If you edit an event or tasks and just dismiss the dialog using e.g. the Escape key the following dialog is shown:

Save Event
Do you want to save changes?
[Yes] [No] [Cancel]

Thunderbird displays a similar dialog if you dismiss the Compose window:

Save Message
Message has not been sent. Do you want to save the message in the Drafts folder?
[Save] [Don't Save] [Cancel]

I suggest to:
- use descriptive button labels "Save"/"Don't Save" instead of "Yes"/"No"
- maybe reword the message text to "Event has not been saved. Do you want to save the event?" and similar for tasks

If I remember correctly there is also a Mozilla guideline or recommendation to use descriptive button labels if possible but I can't find a link at the moment.

Christian, what do you think?

Comment 1

[Christian Jansen]

This makes really sense. We should do that. 

Comment 2

[Stefan Sitter [:ssitter]]

I'll provide a patch after the 0.7 release.

Comment 3

[Stefan Sitter [:ssitter]]

Attachment: reword Save Changes? dialog

Comment 4

[Michael Büttner (no reviews TFN)]

Comment on attachment 284832 [details] [diff] [review]
reword Save Changes? dialog

Looks fine -> r=mickey.

Comment 5

[Christian Jansen]

Comment on attachment 284832 [details] [diff] [review]
reword Save Changes? dialog

ui +  for the proposed changes. For being even more consistent I suggest to change "Yes" to "Save" and "No" to "Don't Save". May we can to this change also in the same bug.

Comment 6

[Stefan Sitter [:ssitter]]

(In reply to comment #5)
This change is already contained in the patch by setting the button text to BUTTON_TITLE_SAVE and BUTTON_TITLE_DONT_SAVE.

Comment 7

[Daniel Boelzle [:dbo]]

Checked in on HEAD and MOZILLA_1_8_BRANCH.

Comment 8

[Omar Bajraszewski]

Verified with lightning 2007102923 and Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8.1.9pre) Gecko/20071030 Calendar/0.8pre