Closed
Bug 395940
Opened 17 years ago
Closed 17 years ago
[Proto] Event Dialog: Save Changes? dialog should use descriptive button labels
Categories
(Calendar :: General, enhancement)
Calendar
General
Tracking
(Not tracked)
VERIFIED
FIXED
0.8
People
(Reporter: ssitter, Assigned: ssitter)
Details
Attachments
(1 file)
3.77 KB,
patch
|
michael.buettner
:
review+
chris.j.bugzilla
:
ui-review+
|
Details | Diff | Splinter Review |
Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.8.1.7pre) Gecko/20070912 Calendar/0.7pre If you edit an event or tasks and just dismiss the dialog using e.g. the Escape key the following dialog is shown: Save Event Do you want to save changes? [Yes] [No] [Cancel] Thunderbird displays a similar dialog if you dismiss the Compose window: Save Message Message has not been sent. Do you want to save the message in the Drafts folder? [Save] [Don't Save] [Cancel] I suggest to: - use descriptive button labels "Save"/"Don't Save" instead of "Yes"/"No" - maybe reword the message text to "Event has not been saved. Do you want to save the event?" and similar for tasks If I remember correctly there is also a Mozilla guideline or recommendation to use descriptive button labels if possible but I can't find a link at the moment. Christian, what do you think?
Comment 1•17 years ago
|
||
This makes really sense. We should do that.
Assignee | ||
Comment 2•17 years ago
|
||
I'll provide a patch after the 0.7 release.
Assignee: nobody → ssitter
Status: UNCONFIRMED → NEW
Ever confirmed: true
Assignee | ||
Comment 3•17 years ago
|
||
Attachment #284832 -
Flags: ui-review?(christian.jansen)
Attachment #284832 -
Flags: review?(michael.buettner)
Comment 4•17 years ago
|
||
Comment on attachment 284832 [details] [diff] [review] reword Save Changes? dialog Looks fine -> r=mickey.
Attachment #284832 -
Flags: review?(michael.buettner) → review+
Updated•17 years ago
|
Whiteboard: [checkin-needed after 0.7]
Updated•17 years ago
|
Status: NEW → ASSIGNED
Comment 5•17 years ago
|
||
Comment on attachment 284832 [details] [diff] [review] reword Save Changes? dialog ui + for the proposed changes. For being even more consistent I suggest to change "Yes" to "Save" and "No" to "Don't Save". May we can to this change also in the same bug.
Attachment #284832 -
Flags: ui-review?(christian.jansen) → ui-review+
Assignee | ||
Comment 6•17 years ago
|
||
(In reply to comment #5) This change is already contained in the patch by setting the button text to BUTTON_TITLE_SAVE and BUTTON_TITLE_DONT_SAVE.
Comment 7•17 years ago
|
||
Checked in on HEAD and MOZILLA_1_8_BRANCH.
Status: ASSIGNED → RESOLVED
Closed: 17 years ago
Resolution: --- → FIXED
Whiteboard: [checkin-needed after 0.7]
Target Milestone: --- → 0.8
Comment 8•17 years ago
|
||
Verified with lightning 2007102923 and Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8.1.9pre) Gecko/20071030 Calendar/0.8pre
Status: RESOLVED → VERIFIED
You need to log in
before you can comment on or make changes to this bug.
Description
•