Closed Bug 396013 Opened 17 years ago Closed 17 years ago

Tracking bug for 0.7 RC cleanup

Categories

(Calendar :: Build Config, defect)

defect
Not set
normal

Tracking

(Not tracked)

VERIFIED FIXED

People

(Reporter: dbo, Unassigned)

References

Details

Attachments

(9 files, 4 obsolete files)

2.50 KB, patch
Fallen
: review+
Details | Diff | Splinter Review
1.07 KB, patch
Details | Diff | Splinter Review
1.25 KB, patch
Fallen
: review+
Details | Diff | Splinter Review
13.44 KB, patch
Details | Diff | Splinter Review
6.98 KB, patch
Details | Diff | Splinter Review
5.94 KB, patch
ssitter
: review+
Details | Diff | Splinter Review
10.83 KB, patch
ssitter
: review+
Details | Diff | Splinter Review
1.30 KB, patch
dbo
: review+
Details | Diff | Splinter Review
15.76 KB, patch
ssitter
: review+
Details | Diff | Splinter Review
IMO it's sufficient for developers to switch firefox support on per build variable, e.g. make LIGHTNING_FIREFOX=1.
Attachment #282126 - Flags: review?(philipp)
Comment on attachment 282126 [details] [diff] [review]
[checked in] firefox support optional

Isn't it sufficient to just do 

DEFINES += -DLIGHTNING_FIREFOX=$(LIGHTNING_FIREFOX)

and in the install rdf use

#if LIGHTNING_FIREFOX
...
#endif

I am assuming this from [1], I don't know how trunk-only or not it is...

[1] http://developer.mozilla.org/en/docs/Build:Text_Preprocessor#if


r+ with that investigated.
Attachment #282126 - Flags: review?(philipp) → review+
(In reply to comment #2)
Works equally good, but is shorter; checked in on HEAD and MOZILLA_1_8_BRANCH.
Attachment #282538 - Flags: review?(philipp)
Attachment #282126 - Attachment description: firefox support optional → [checked in] firefox support optional
Attachment #282531 - Attachment description: changing to branch tag for 0.7 release - belongs to SUNBIRD_0_7_BRANCH only → [checked in] changing to branch tag for 0.7 release - belongs to SUNBIRD_0_7_BRANCH only
Comment on attachment 282538 [details] [diff] [review]
[checked in] switching version for SUNBIRD_0_7_BRANCH

Looks fine to me. ssitter should have more insight if needed.
Attachment #282538 - Flags: review?(philipp) → review+
Attachment #282538 - Attachment description: switching version for SUNBIRD_0_7_BRANCH → [checked in] switching version for SUNBIRD_0_7_BRANCH
Attached patch switch regular tinderboxes to release mode (obsolete) — — Splinter Review
Attached patch switch l10n tinderboxes to release mode (obsolete) — — Splinter Review
(In reply to comment #6)
Yes, should be correct. So from looking at the past release we just need to

MOZILLA_1_8_BRANCH

    Sunbird/Lightning tinder-config.pl (all):
        set $BuildTag to SUNBIRD_0_7_RELEASE resp. LIGHTNING_0_7_RELEASE
        set $BuildNameExtra to 'Sb-Release' resp. 'Lt-Release'
        set $ProductName to 'Sunbird'
    Sunbird tinder-config.pl (macosx):
        set $MacOSProductName to 'Sunbird'
    Sunbird mozconfig (all):
        set ac_add_options --enable-update-channel="release"
        set ac_add_options --enable-official-branding
    
MOZILLA_1_8_BRANCH_l10n

    Sunbird tinder-config.pl (all):
        set $BuildTag to SUNBIRD_0_7_RELEASE
        set $ProductName to 'Sunbird'

        optional: set a new %WGetFiles to repackage the same RC build instead of latest-mozilla1.8 build, e.g. from http://ftp.mozilla.org/pub/mozilla.org/calendar/sunbird/nightly/candidates/

    Sunbird tinder-config.pl (macosx):
        set $MacOSProductName to 'Sunbird'
    Sunbird mozconfig (all):
        set ac_add_options --enable-official-branding

I hope I don't misses something ...
Attached patch fixed branchtag for lightning (obsolete) — — Splinter Review
Attachment #282558 - Attachment is obsolete: true
Attachment #282560 - Attachment is obsolete: true
we should do a clobber build once the tinderboxes are switched
Comment on attachment 282559 [details] [diff] [review]
switch l10n tinderboxes to release mode

>--- sunbird/macosx/tinder-config.pl 24 Jul 2007 01:11:46 -0000	1.32.2.13
>+++ sunbird/macosx/tinder-config.pl 27 Sep 2007 17:14:21 -0000
>+$BuildTag = 'SUNBIRD_0_5_BRANCH';

I suggest to use the 0.7 branch
Attached patch l10n tinderbox - now with better tags (obsolete) — — Splinter Review
Comment on attachment 282559 [details] [diff] [review]
switch l10n tinderboxes to release mode

obsoleted by 282661
Attachment #282559 - Attachment is obsolete: true
Attachment #282566 - Attachment description: switch regular tinderboxes to release mode - more fixes → [checked in] switch regular tinderboxes to release mode - more fixes
Attachment #282690 - Attachment description: switch l10n tinderboxes to 0.7 release branch - leave WGetFiles entry unchanged → [checked in] switch l10n tinderboxes to 0.7 release branch - leave WGetFiles entry unchanged
Error in RC1: install.rdf in lightning-wcap-0.7.mac.xpi lists only Darwin_ppc-gcc3 as supported target platform but omits Darwin_x86-gcc3.
Error in RC2: Broken mn local is still contained in the lightning.xpi packages. 
This local should be excluded from 0.7 release.
Comment on attachment 286162 [details] [diff] [review]
switch lightning tb back to dev mode

to have another pair of eyes was helpfull on the previous switch
Attachment #286162 - Flags: review?(ssitter)
Attachment #286163 - Flags: review?(ssitter)
Comment on attachment 286162 [details] [diff] [review]
switch lightning tb back to dev mode

r=ssitter
Attachment #286162 - Flags: review?(ssitter) → review+
Comment on attachment 286163 [details] [diff] [review]
switch sunbird tb back to dev mode

r=ssitter
Attachment #286163 - Flags: review?(ssitter) → review+
Attachment #286166 - Flags: review?(daniel.boelzle)
Comment on attachment 286166 [details] [diff] [review]
switch version number to 0.8pre on MOZILLA_1_8_BRANCH

r=dbo; checked in on MOZILLA_1_8_BRANCH
Attachment #286166 - Flags: review?(daniel.boelzle) → review+
After the version bump, you'll need to update
  http://mxr.mozilla.org/mozilla/source/webtools/aus/xml/inc/config-dist.php
for nightly updates to work again - request review from morgamic and he'll do the rest.
Attachment #286556 - Flags: review?(ssitter)
Comment on attachment 286556 [details] [diff] [review]
l10n tinderboxes back to nightly mode

r=ssitter
Attachment #286556 - Flags: review?(ssitter) → review+
Depends on: 401749
The l10n tinderboxes were changed back to MOZILLA_1_8_BRANCH. Can we close this bug?
Status: NEW → RESOLVED
Closed: 17 years ago
Resolution: --- → FIXED
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: