The default bug view has changed. See this FAQ.

Warning: usage of uninitialized variable in ckfw/object.c(174)

RESOLVED FIXED in 3.12

Status

NSS
Libraries
RESOLVED FIXED
10 years ago
9 years ago

People

(Reporter: Bruno 'Aqualon' Escherl, Assigned: Bruno 'Aqualon' Escherl)

Tracking

unspecified
3.12

Firefox Tracking Flags

(Not tracked)

Details

(URL)

Attachments

(1 attachment)

(Assignee)

Description

10 years ago
VC8 reports a warning C4700, cause *fwObject isn't initialized before it's returned (see URL).
(Assignee)

Comment 1

9 years ago
Created attachment 290980 [details] [diff] [review]
return NULL instead of uninitialized fwObject

The patch changes the return value to (NSSCKFWObject *)NULL (like it's done in similar cases before and after the changed line in that file).
Assignee: nobody → aqualon
Status: NEW → ASSIGNED
Attachment #290980 - Flags: review?(nelson)
Comment on attachment 290980 [details] [diff] [review]
return NULL instead of uninitialized fwObject

Let's ask the author for review
Attachment #290980 - Flags: review?(nelson) → review?(rrelyea)

Comment 3

9 years ago
Comment on attachment 290980 [details] [diff] [review]
return NULL instead of uninitialized fwObject

r+ rrelyea

or alternately fwObject could be initialized to NULL, but this patch follows the existing style better.

bob
Attachment #290980 - Flags: review?(rrelyea) → review+
(Assignee)

Updated

9 years ago
Keywords: checkin-needed
NSS is restricted, so somebody from NSS will need to commit this for you.
wtc, mind landing this for Aqualon? I don't have access to NSS.

Comment 6

9 years ago
I checked in the patch on the NSS trunk for NSS 3.12.

Checking in object.c;
/cvsroot/mozilla/security/nss/lib/ckfw/object.c,v  <--  object.c
new revision: 1.15; previous revision: 1.14
done
Status: ASSIGNED → RESOLVED
Last Resolved: 9 years ago
Keywords: checkin-needed
OS: Windows XP → All
Hardware: PC → All
Resolution: --- → FIXED
Target Milestone: --- → 3.12
You need to log in before you can comment on or make changes to this bug.