Last Comment Bug 396045 - Warning: usage of uninitialized variable in ckfw/mechanism.c(719)
: Warning: usage of uninitialized variable in ckfw/mechanism.c(719)
Status: RESOLVED FIXED
:
Product: NSS
Classification: Components
Component: Libraries (show other bugs)
: unspecified
: All All
: -- normal (vote)
: 3.12
Assigned To: Bruno 'Aqualon' Escherl
:
:
Mentors:
http://bonsai.mozilla.org/cvsblame.cg...
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2007-09-13 09:20 PDT by Bruno 'Aqualon' Escherl
Modified: 2007-12-11 16:51 PST (History)
2 users (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---


Attachments
move the NULL check to the correct position in the code (1.72 KB, patch)
2007-12-01 05:44 PST, Bruno 'Aqualon' Escherl
rrelyea: review+
Details | Diff | Splinter Review

Description Bruno 'Aqualon' Escherl 2007-09-13 09:20:18 PDT
VC8 reports a warning C4700, cause mdOperation isn't initialized before it's used in a comparison (see URL).
Comment 1 Bruno 'Aqualon' Escherl 2007-12-01 05:44:40 PST
Created attachment 290982 [details] [diff] [review]
move the NULL check to the correct position in the code

The check if mdOperation is NULL should happen after mdOperation is initialized and not before (e.g. like it's done in nssCKFWMechanism_SignInit).
Comment 2 Nelson Bolyard (seldom reads bugmail) 2007-12-01 20:08:03 PST
Comment on attachment 290982 [details] [diff] [review]
move the NULL check to the correct position in the code

Ask the author for review
Comment 3 Robert Relyea 2007-12-03 12:00:03 PST
Comment on attachment 290982 [details] [diff] [review]
move the NULL check to the correct position in the code

r+ rrelyea
Comment 4 Reed Loden [:reed] (use needinfo?) 2007-12-03 20:10:03 PST
NSS is restricted, so somebody from NSS will need to commit this for you.
Comment 5 Reed Loden [:reed] (use needinfo?) 2007-12-11 11:30:56 PST
wtc, mind landing this for Aqualon? I don't have access to NSS.
Comment 6 Wan-Teh Chang 2007-12-11 16:51:38 PST
I checked in the patch on the NSS trunk for NSS 3.12.

Checking in mechanism.c;
/cvsroot/mozilla/security/nss/lib/ckfw/mechanism.c,v  <--  mechanism.c
new revision: 1.5; previous revision: 1.4
done

Note You need to log in before you can comment on or make changes to this bug.