Warning: usage of uninitialized variable in ckfw/mechanism.c(719)

RESOLVED FIXED in 3.12

Status

NSS
Libraries
RESOLVED FIXED
10 years ago
10 years ago

People

(Reporter: Bruno 'Aqualon' Escherl, Assigned: Bruno 'Aqualon' Escherl)

Tracking

unspecified
3.12

Firefox Tracking Flags

(Not tracked)

Details

(URL)

Attachments

(1 attachment)

(Assignee)

Description

10 years ago
VC8 reports a warning C4700, cause mdOperation isn't initialized before it's used in a comparison (see URL).
(Assignee)

Comment 1

10 years ago
Created attachment 290982 [details] [diff] [review]
move the NULL check to the correct position in the code

The check if mdOperation is NULL should happen after mdOperation is initialized and not before (e.g. like it's done in nssCKFWMechanism_SignInit).
Assignee: nobody → aqualon
Status: NEW → ASSIGNED
Attachment #290982 - Flags: review?(nelson)
Comment on attachment 290982 [details] [diff] [review]
move the NULL check to the correct position in the code

Ask the author for review
Attachment #290982 - Flags: review?(nelson) → review?(rrelyea)

Comment 3

10 years ago
Comment on attachment 290982 [details] [diff] [review]
move the NULL check to the correct position in the code

r+ rrelyea
Attachment #290982 - Flags: review?(rrelyea) → review+
(Assignee)

Updated

10 years ago
Keywords: checkin-needed
NSS is restricted, so somebody from NSS will need to commit this for you.
wtc, mind landing this for Aqualon? I don't have access to NSS.

Comment 6

10 years ago
I checked in the patch on the NSS trunk for NSS 3.12.

Checking in mechanism.c;
/cvsroot/mozilla/security/nss/lib/ckfw/mechanism.c,v  <--  mechanism.c
new revision: 1.5; previous revision: 1.4
done
Status: ASSIGNED → RESOLVED
Last Resolved: 10 years ago
Keywords: checkin-needed
OS: Windows XP → All
Hardware: PC → All
Resolution: --- → FIXED
Target Milestone: --- → 3.12
You need to log in before you can comment on or make changes to this bug.