396045 - Warning: usage of uninitialized variable in ckfw/mechanism.c(719)

Status: RESOLVED FIXED

(NSS :: Libraries, defect)

Description

[Bruno 'Aqualon' Escherl]

VC8 reports a warning C4700, cause mdOperation isn't initialized before it's used in a comparison (see URL).

Comment 1

[Bruno 'Aqualon' Escherl]

Attachment: move the NULL check to the correct position in the code

The check if mdOperation is NULL should happen after mdOperation is initialized and not before (e.g. like it's done in nssCKFWMechanism_SignInit).

Comment 2

[Nelson Bolyard (seldom reads bugmail)]

Comment on attachment 290982 [details] [diff] [review]
move the NULL check to the correct position in the code

Ask the author for review

Comment 3

[Robert Relyea]

Comment on attachment 290982 [details] [diff] [review]
move the NULL check to the correct position in the code

r+ rrelyea

Comment 4

[Reed Loden [:reed]]

NSS is restricted, so somebody from NSS will need to commit this for you.

Comment 5

[Reed Loden [:reed]]

wtc, mind landing this for Aqualon? I don't have access to NSS.

Comment 6

[Wan-Teh Chang]

I checked in the patch on the NSS trunk for NSS 3.12.

Checking in mechanism.c;
/cvsroot/mozilla/security/nss/lib/ckfw/mechanism.c,v  <--  mechanism.c
new revision: 1.5; previous revision: 1.4
done