396075 - "New Calendar" dialog: sentences should get punctuation marks

Status: VERIFIED FIXED

(Calendar :: General, defect)

Description

[Robert Brand]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; de; rv:1.8.1.6) Gecko/20070725 Firefox/2.0.0.6
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8.1.7pre) Gecko/20070913 Calendar/0.7pre

When creating a new local or remote calendar several sentences in the dialog look incomplete. They should end with a colon or full stop:

New local calendar (steps 2+3):
"You can give your calendar a nickname and colorize the events from this calendar"
"Your calendar has been created"

New remote calendar (steps 2-4):
"Provide info about what is needed to access your remote calendar"
"You can give your calendar a nickname and colorize the events from this calendar"
"Your calendar has been created"

Reproducible: Always

Steps to Reproduce:
Call the new calendar dialog and follow the instructions.

Comment 1

[Martin Schröder [:mschroeder]]

Confirmed with Lightning 0.7pre (2007092903).

Comment 2

[Ronald Hermes]

Does apply to latest Lightning 0.8pre (build 2008022218)

Comment 3

[Simon Paquet [:sipaq]]

Attachment: Patch v1

From the three sentences that are referenced in the bug description I chose to give punctuation marks to only two of them.

"Provide info about what is needed to access your remote calendar" is no real sentence in my book and therefore should get no punctuation mark.

Comment 4

[Simon Paquet [:sipaq]]

Patch checked in.

Comment 5

[Andreas Treumann]

Checked in lightning 2008061918 -> VERIFIED