396084 - location bar flickers on hover

Status: VERIFIED FIXED

(Firefox :: Address Bar, defect)

Description

[Robert Sayre]

Steps to reproduce:

1.) Move the mouse back and forth over the URL on "http://www.google.com". The "oo" part of the url has glitches.

I've also seen this happen on pageload, but it's harder to reproduce.

Comment 1

[:Gavin Sharp [email: [e-mail]]]

This is probably a dupe of bug 386759, but I asked Rob to file this because I'm not sure that we should even that hover code now that we don't appear to be using it. Dao?

Comment 2

[Dão Gottwald [:dao]]

Robert, do the letters move or does their color/opacity flicker? The former would be bug 386759 (only reported for Linux so far) and the latter would be fixed by the patch in bug 388030.

(In reply to comment #1)
> [...] now that we don't appear to be using it.

I don't know if there's a plan, maybe it fell off mconnor's radar. If it stays at it is, the binding could be simplified, although I'd still prefer to support the browser.urlbar.hideProtocols pref even if it's empty by default.

Comment 3

[:Gavin Sharp [email: [e-mail]]]

One way to reproduce the flicker is to focus the location bar and then tab out of it (this is in a build with the patch in bug 386759).

Comment 4

[Dão Gottwald [:dao]]

(In reply to comment #3)
> One way to reproduce the flicker is to focus the location bar and then tab out
> of it (this is in a build with the patch in bug 386759).

We can optimize this further; e.g. disable fading if the protocol isn't hidden, although that would also disable fading if the use customized the url formatting.

Comment 5

[Dão Gottwald [:dao]]

(In reply to comment #4)
> We can optimize this further; e.g. disable fading if the protocol isn't hidden

I've added this to patch v4 in bug 388030.

Comment 6

[Dão Gottwald [:dao]]

Apparently the fading algorithm is also a bit flawed, in that two translucent surfaces can't add up to something fully opaque.

This seems to work better for me:

>             inputField.style.setProperty("opacity", opacity, "important");
>-            formattedURL.style.setProperty("opacity", 1-opacity, "important");
>+            formattedURL.style.setProperty("opacity", (1-opacity) * 1.2, "important");

Comment 7

[Dão Gottwald [:dao]]

see also bug 379786

Comment 8

[Stephen Donner [:stephend] Not actively reading bugmail]

I'm not seeing flicker any longer (haven't been for a while), with:

Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9b3pre) Gecko/2008011504 Minefield/3.0b3pre

Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.4; en-US; rv:1.9b3pre) Gecko/2008011504 Minefield/3.0b3pre

nor

Mozilla/5.0 (Windows; U; Windows NT 6.0; en-US; rv:1.9b3pre) Gecko/2008011504 Minefield/3.0b3pre

Verified FIXED