396095 - tp-component.zip generation script (from pageloader/ directory)

Status: RESOLVED FIXED

(Release Engineering :: General, defect)

Description

[alice nodelman [:alice] [:anode]]

Attachment: tp-component.zip generation script

This script takes the contents of mozilla/layout/tools/pageloader and creates a tp-component.zip archive containing correctly formatted chrome/ and components/ directories.  This can be used to have Talos boxes be able to auto-update the pageloader when changes are checked in.  

If we don't want it all zipped up the script could be altered to simply create chrome/ and components/ directories.

I'm not sure if this belongs in the pageloader directory or the talos code, or possibly the buildbot scripts.

Comment 1

[[e-mail] (:bhearsum)]

Attachment: generates chrome/ and components/ in cwd

This is a slightly modified version of your script that generates the chrome/ and component/ directories in the current working directory. This is what will be used on the Talos slaves.

Comment 2

[[e-mail] (:bhearsum)]

Attachment: do it properly this time (generates the pageloader.jar)

This version generates the pageloader properly. I also added a few comments.

Comment 3

[alice nodelman [:alice] [:anode]]

If run twice in a row you run into this problem:

Traceback (most recent call last):
  File "buildpl.py", line 45, in ?
    os.mkdir(os.path.join(working_dir, 'chrome'))
OSError: [Errno 17] File exists: './chrome'

This would be because the chrome/component directories aren't cleaned up between runs.  Will this affect functionality with buildbot?  Is buildbot handling the cleanup?

Comment 4

[[e-mail] (:bhearsum)]

Buildbot is handling the clean-up, though that should probably be handled more gracefully. I'll put up a nicer version tomorrow.

Comment 5

[[e-mail] (:bhearsum)]

Attachment: same as before, but more user friendly

This version works exactly like the last one but bails if chrome/ or components/ exists in the working_dir. It will also bail if the cvs checkout fails.

Comment 6

[[e-mail] (:bhearsum)]

I keep missing this when I go through my bugs so I'm going to assign it to me.

Comment 7

[[e-mail] (:bhearsum)]

Attachment: same as before, with cvs-mirror.m.o and patchification

Here's an updated version that uses cvs-mirror by default. I'm proposing that we put it in talos/page_load_test. I think it belongs with Talos as it will be very useful for stand-alone Talos. Not to mention it makes the Buildbot configuration a bit shorter.

Comment 8

[alice nodelman [:alice] [:anode]]

Comment on attachment 281753 [details] [diff] [review]
same as before, with cvs-mirror.m.o and patchification

Thanks for th cvs-mirror change.  It will make it simpler for other users to generate chrome/component directories.

Comment 9

[alice nodelman [:alice] [:anode]]

This was checked in as part of bug 395819.

RCS file:
/cvsroot/mozilla/tools/buildbot-configs/testing/talos/perfmaster/scripts/generate-tpcomponent.py,v
done
Checking in scripts/generate-tpcomponent.py;
/cvsroot/mozilla/tools/buildbot-configs/testing/talos/perfmaster/scripts/generate-tpcomponent.py,v
 <--  generate-tpcomponent.py
initial revision: 1.1

Comment 10

[(not currently active) Ted Mielczarek]

Mass move of Core:Testing bugs to mozilla.org:ReleaseEngineering. Filter on RelEngMassMove to ignore.