Closed Bug 396134 Opened 12 years ago Closed 10 years ago
Bookmarks Manager buttons are missing tooltips
Build ID: Mozilla/5.0 (Macintosh; U; Intel Mac OS X; en-US; rv:1.9a8pre) Gecko/2007091304 Minefield/3.0a8pre Summary: Bookmarks Manager buttons are missing tooltips Steps to Reproduce: 1. Open Bookmarks | Organize Bookmarks 2. Hover over each of the buttons Expected Results: Each button yields a tooltip Actual Results: On no platform is there a tooltip for any button
Hmm they have the code for it but I don't think the dtd file is referenced or imported at all to get the text to be shown. http://mxr.mozilla.org/mozilla/source/browser/components/places/content/places.xul#168
Flags: blocking-firefox3? → blocking-firefox3+
I know this was filed on Places, but isn't this a Dupe of Bug 237592, "Bookmarks should always show tooltip when hovering with mouse" - https://bugzilla.mozilla.org/show_bug.cgi?id=237592 ??
(In reply to comment #2) > I know this was filed on Places, but isn't this a Dupe of Bug 237592, > "Bookmarks should always show tooltip when hovering with mouse" - > https://bugzilla.mozilla.org/show_bug.cgi?id=237592 ?? Bookmarks!=buttons, so no. Also, this was filed before the current buttons were implemented; right now, the "Organize," "Views," and "Import and Backup" buttons still need tooltips.
So, these are menus, though the visual isn't quite right there. I wouldn't class this as major either way.
Severity: major → minor
Priority: -- → P4
Wanted, but not blocking.
Test case https://litmus.mozilla.org/show_test.cgi?id=7483 has been added to litmus 3.0testrun for regression testing.
Flags: in-litmus? → in-litmus+
Bug 451915 - move Firefox/Places bugs to Firefox/Bookmarks and History. Remove all bugspam from this move by filtering for the string "places-to-b-and-h". In Thunderbird 3.0b, you do that as follows: Tools | Message Filters Make sure the correct account is selected. Click "New" Conditions: Body contains places-to-b-and-h Change the action to "Delete Message". Select "Manually Run" from the dropdown at the top. Click OK. Select the filter in the list, make sure "Inbox" is selected at the bottom, and click "Run Now". This should delete all the bugspam. You can then delete the filter. Gerv
Component: Places → Bookmarks & History
QA Contact: places → bookmarks
This adds tooltips to the toolbarbuttons. Please feel free to suggest other, better text.
Assignee: nobody → michaelkohler
Status: NEW → ASSIGNED
Comment on attachment 456059 [details] [diff] [review] Patch v1 get ui-review first
Attachment #456059 - Flags: ui-review?(faaborg)
"Import and Backup to maintain the profile" looks confusing about the "maintain" scope. I'd maybe say "Import or backup bookmarks for this profile". Btw Alex could have better ideas.
Comment on attachment 456059 [details] [diff] [review] Patch v1 We don't currently end our tooltips with a period, so for consistency we should avoid them here while still maintaining sentence case. New text: <!ENTITY organize.tooltip "Organize your bookmarks"> <!ENTITY views.tooltip "Change your view"> <!ENTITY maintenance.tooltip "Import and backup your bookmarks">
Attachment #456059 - Flags: ui-review?(faaborg) → ui-review-
changed the phrasing according to Alex' suggestion.
Attachment #456917 - Flags: review?(gavin.sharp) → review+
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 4.0b2
Verified FIXED; thanks!
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.