396134 - Bookmarks Manager buttons are missing tooltips

Status: VERIFIED FIXED

(Firefox :: Bookmarks & History, defect, P4)

Description

[Stephen Donner [:stephend] Not actively reading bugmail]

Build ID: Mozilla/5.0 (Macintosh; U; Intel Mac OS X; en-US; rv:1.9a8pre) Gecko/2007091304 Minefield/3.0a8pre

Summary: Bookmarks Manager buttons are missing tooltips

Steps to Reproduce:

1. Open Bookmarks | Organize Bookmarks
2. Hover over each of the buttons

Expected Results:

Each button yields a tooltip

Actual Results:

On no platform is there a tooltip for any button

Comment 1

[u88484]

Hmm they have the code for it but I don't think the dtd file is referenced or imported at all to get the text to be shown.

http://mxr.mozilla.org/mozilla/source/browser/components/places/content/places.xul#168

Comment 2

[RenegadeX]

I know this was filed on Places, but isn't this a Dupe of Bug 237592, "Bookmarks should always show tooltip when hovering with mouse" - https://bugzilla.mozilla.org/show_bug.cgi?id=237592  ??

Comment 3

[Stephen Donner [:stephend] Not actively reading bugmail]

(In reply to comment #2)
> I know this was filed on Places, but isn't this a Dupe of Bug 237592,
> "Bookmarks should always show tooltip when hovering with mouse" -
> https://bugzilla.mozilla.org/show_bug.cgi?id=237592  ??

Bookmarks!=buttons, so no.

Also, this was filed before the current buttons were implemented; right now, the "Organize," "Views," and "Import and Backup" buttons still need tooltips.

Comment 4

[Mike Connor [:mconnor]]

So, these are menus, though the visual isn't quite right there.

I wouldn't class this as major either way.

Comment 5

[Mike Connor [:mconnor]]

Wanted, but not blocking.

Comment 6

[Aakash Desai [:aakashd]]

Test case https://litmus.mozilla.org/show_test.cgi?id=7483 has been added to litmus 3.0testrun for regression testing.

Comment 7

[Gervase Markham [:gerv]]

Bug 451915 - move Firefox/Places bugs to Firefox/Bookmarks and History. Remove all bugspam from this move by filtering for the string "places-to-b-and-h".

In Thunderbird 3.0b, you do that as follows:
Tools | Message Filters
Make sure the correct account is selected. Click "New"
Conditions: Body   contains   places-to-b-and-h
Change the action to "Delete Message".
Select "Manually Run" from the dropdown at the top.
Click OK.

Select the filter in the list, make sure "Inbox" is selected at the bottom, and click "Run Now". This should delete all the bugspam. You can then delete the filter.

Gerv

Comment 8

[Michael Kohler [:mkohler]]

Attachment: Patch v1

This adds tooltips to the toolbarbuttons. Please feel free to suggest other, better text.

Comment 9

[:Gavin Sharp [email: [e-mail]]]

Comment on attachment 456059 [details] [diff] [review]
Patch v1

get ui-review first

Comment 10

[Marco Bonardo [:mak]]

"Import and Backup to maintain the profile" looks confusing about the "maintain" scope. I'd maybe say "Import or backup bookmarks for this profile". Btw Alex could have better ideas.

Comment 11

[Alex Faaborg [:faaborg] (Firefox UX)]

Comment on attachment 456059 [details] [diff] [review]
Patch v1

We don't currently end our tooltips with a period, so for consistency we should avoid them here while still maintaining sentence case.  New text:

<!ENTITY organize.tooltip      "Organize your bookmarks">
<!ENTITY views.tooltip                  "Change your view">
<!ENTITY maintenance.tooltip    "Import and backup your bookmarks">

Comment 12

[Michael Kohler [:mkohler]]

Attachment: Patch v2

changed the phrasing according to Alex' suggestion.

Comment 13

[Dão Gottwald [:dao]]

http://hg.mozilla.org/mozilla-central/rev/53078cea96ee

Comment 14

[Stephen Donner [:stephend] Not actively reading bugmail]

Verified FIXED; thanks!