Closed Bug 396232 Opened 14 years ago Closed 14 years ago
.config for all platforms
In an attempt to clean up the talos configuration world I've come up with this: - entirely get rid of config.py - move everything into sample.config - normalize all paths in sample.config to be workable across platforms (ie, a path of 'pageloader/chrome' will be correctly interpreted as 'pageloader\chrome' on windows) - to handle the different counter options under different platforms created win_counters and unix_counters, which are correctly used depending on the system - add a --debug option and get that out of the config file So, as long as things are installed in the 'standard' locations you should be able to run talos across win/mac/linux using the same sample.config. The only change that you should have to make is the name of firefox (as it will be firefox.exe on windows and firefox on unix style systems). If this last requirement would get in the way it could be hacked to guess the correct name for a firefox executable on different systems. I'm hoping that this will help alleviate the problem of managing config files for multiple systems/configurations.
Attachment #280954 - Flags: review?(bhearsum)
Everything in the patch looks good. I'd like to test it out for myself on all 3 platforms before giving it an r+. For Buildbot purposes the firefox executable path is unimportant, it gets overriden by PerfConfigurator.py anyways. I'm going to test this out Monday morning, so you'll probably have an r+ when you come online ;)
Comment on attachment 280954 [details] [diff] [review] sample.config cross platform work Running fine on all three platforms. One thing I noticed about Linux is that during ts it throws "WARNING: can't start counter manager", presumably because by the time talos is done sleeping firefox is already closed. Seems to work fine, though.
Attachment #280954 - Flags: review?(bhearsum) → review+
Removing config.py; /cvsroot/mozilla/testing/performance/talos/config.py,v <-- config.py new revision: delete; previous revision: 1.7 done Checking in ffprocess.py; /cvsroot/mozilla/testing/performance/talos/ffprocess.py,v <-- ffprocess.py new revision: 1.6; previous revision: 1.5 done Checking in ffprocess_linux.py; /cvsroot/mozilla/testing/performance/talos/ffprocess_linux.py,v <-- ffprocess_linux.py new revision: 1.5; previous revision: 1.4 done Checking in ffprocess_mac.py; /cvsroot/mozilla/testing/performance/talos/ffprocess_mac.py,v <-- ffprocess_mac.py new revision: 1.3; previous revision: 1.2 done Checking in ffprocess_win32.py; /cvsroot/mozilla/testing/performance/talos/ffprocess_win32.py,v <-- ffprocess_win32.py new revision: 1.4; previous revision: 1.3 done Checking in ffsetup.py; /cvsroot/mozilla/testing/performance/talos/ffsetup.py,v <-- ffsetup.py new revision: 1.2; previous revision: 1.1 done Checking in run_tests.py; /cvsroot/mozilla/testing/performance/talos/run_tests.py,v <-- run_tests.py new revision: 1.10; previous revision: 1.9 done Checking in sample.config; /cvsroot/mozilla/testing/performance/talos/sample.config,v <-- sample.config new revision: 1.7; previous revision: 1.6 done Checking in ttest.py; /cvsroot/mozilla/testing/performance/talos/ttest.py,v <-- ttest.py new revision: 1.2; previous revision: 1.1 done Checking in utils.py; /cvsroot/mozilla/testing/performance/talos/utils.py,v <-- utils.py new revision: 1.2; previous revision: 1.1 done
Status: NEW → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
Mass move of Core:Testing bugs to mozilla.org:Release Engineering:Talos. Filter on RelEngTalosMassMove to ignore.
Component: Testing → Release Engineering: Talos
Product: Core → mozilla.org
QA Contact: testing → release
Version: Trunk → other
Product: mozilla.org → Release Engineering
You need to log in before you can comment on or make changes to this bug.