Closed Bug 396337 Opened 17 years ago Closed 17 years ago

Some tooltips should be improved

Categories

(Calendar :: General, defect)

defect
Not set
normal

Tracking

(Not tracked)

VERIFIED FIXED

People

(Reporter: hubert+bmo, Assigned: hubert+bmo)

References

()

Details

Attachments

(1 file)

1.49 KB, patch
michael.buettner
: review+
chris.j.bugzilla
: ui-review+
Details | Diff | Splinter Review
Attached patch Patch for trunkSplinter Review
We have some tooltips which should be improve:
<!ENTITY calendar.import.button.tooltip            "Import: Import events from a local file." >
<!ENTITY calendar.export.button.tooltip            "Export: Export events to a local file." >
<!ENTITY calendar.subscribe.button.tooltip         "Subscribe: Subscribe to a calendar file on a remote machine." >
<!ENTITY calendar.publish.button.tooltip            "Publish: Publish events to a remote machine." >

My proposal:
<!ENTITY calendar.import.button.tooltip            "Import events from a local file" >
<!ENTITY calendar.export.button.tooltip            "Export events to a local file" >
<!ENTITY calendar.subscribe.button.tooltip         "Subscribe to a calendar file on a remote machine" >
<!ENTITY calendar.publish.button.tooltip            "Publish events to a remote machine" >
Attachment #281077 - Flags: review?(christian.jansen)
Summary: Some tooltips should be improve → Some tooltips should be improved
Comment on attachment 281077 [details] [diff] [review]
Patch for trunk

Hubert, Christian is our resident UI expert. Therefore he gives UI-review. Moving the review-request to mickey.

As a sidenote, we will not fix this in the 0.7 timeframe to keep the string freeze. But you can of course incorporate these changes in your Polish localization if you think that this is appropriate.
Attachment #281077 - Flags: ui-review?(christian.jansen)
Attachment #281077 - Flags: review?(michael.buettner)
Attachment #281077 - Flags: review?(christian.jansen)
Comment on attachment 281077 [details] [diff] [review]
Patch for trunk

ui=christian. Thanks for the patch. It improves the readability of the ToolTips.
Attachment #281077 - Flags: ui-review?(christian.jansen) → ui-review+
Assignee: nobody → hubert.gajewski
OS: Linux → All
Hardware: PC → All
Version: Trunk → unspecified
Status: NEW → ASSIGNED
Comment on attachment 281077 [details] [diff] [review]
Patch for trunk

>+<!ENTITY calendar.import.button.tooltip            "Import events from a local file" >
>+<!ENTITY calendar.export.button.tooltip            "Export events to a local file" >
>+<!ENTITY calendar.subscribe.button.tooltip         "Subscribe to a calendar file on a remote machine" >
>+<!ENTITY calendar.publish.button.tooltip            "Publish events to a remote machine" >
I would like to line the strings up, but I'll fix that before checking it in. Thanks for the patch -> r=mickey.
Attachment #281077 - Flags: review?(michael.buettner) → review+
Keywords: checkin-needed
Whiteboard: [checkin-needed after 0.7]
patch checked in on trunk and MOZILLA_1_8_BRANCH

-> FIXED
Status: ASSIGNED → RESOLVED
Closed: 17 years ago
Resolution: --- → FIXED
Whiteboard: [checkin-needed after 0.7]
Target Milestone: --- → 0.8
I can confirm that the tooltips are working fine with lightning build 2007121104. But I've a small complaint. The tool tip for the Print button says "Print Calendar". The first letter of the second word is in capitals. For the rest of the tool tips the words following the first are all in lower case. I think you should change the tool tip for the Print button to be consistent with the rest of the buttons' tool tips. Thanks.
Verified with Lightning 2008012900 and Mozilla/5.0 (Windows; U; Windows NT 5.1;
pl; rv:1.8.1.12pre) Gecko/20080127 Calendar/0.8pre
Status: RESOLVED → VERIFIED
Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8.1.9) Gecko/20071031 Lightning/0.8pre (2008012818) Thunderbird/2.0.0.9 ID:2007103104

VERIFIED
You need to log in before you can comment on or make changes to this bug.