Calculate selected state for currently active ARIA tab

RESOLVED FIXED

Status

()

Core
Disability Access APIs
RESOLVED FIXED
10 years ago
10 years ago

People

(Reporter: Aaron Leventhal, Assigned: surkov)

Tracking

(Blocks: 1 bug, {access})

Trunk
access
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(2 attachments, 1 obsolete attachment)

10.58 KB, application/xhtml+xml
Details
1.93 KB, patch
Aaron Leventhal
: review+
damons
: approval1.9+
Details | Diff | Splinter Review
(Reporter)

Description

10 years ago
An ARIA tab should have STATE_SELECTED if the current focus (gLastFocusedNode) is inside the tab container it is a label for.
(Assignee)

Comment 1

10 years ago
Created attachment 281799 [details] [diff] [review]
like this?
Attachment #281799 - Flags: review?(aaronleventhal)
(Assignee)

Comment 2

10 years ago
testcase http://test.cita.uiuc.edu/aria/tabpanel/tabpanel1.php, but not sure how to test it due to focus is changed.
(Reporter)

Comment 3

10 years ago
Comment on attachment 281799 [details] [diff] [review]
like this?

The code looks good but we need to test it. What do you mean focus has changed?

Can you fix the Mozilla testcase so it uses labelledby?
http://www.mozilla.org/access/dhtml/tabpanel
(Reporter)

Comment 4

10 years ago
Comment on attachment 281799 [details] [diff] [review]
like this?

Clearing review until we get test results.
Attachment #281799 - Flags: review?(aaronleventhal)
(Assignee)

Comment 5

10 years ago
Created attachment 281952 [details]
testcase

yes, it works. Though should we set 'selected' if tab has focused state?
Assignee: aaronleventhal → surkov.alexander
Status: NEW → ASSIGNED
(Assignee)

Updated

10 years ago
Attachment #281799 - Flags: review?(aaronleventhal)
(Assignee)

Comment 6

10 years ago
(In reply to comment #3)

> Can you fix the Mozilla testcase so it uses labelledby?
> http://www.mozilla.org/access/dhtml/tabpanel
> 

How can I do it? Should I have special rights?
(Reporter)

Comment 7

10 years ago
Surkov, you can just to use your regular CVS account.

See http://www.mozilla.org/contribute/writing/cvs
You can check out the mozilla.org content tree with 
cvs co MozillaOrgTrim

To get the mozilla.org/access tree I think you'll need to
cd docs/mozilla-org/html

cvs up -d access

(Reporter)

Comment 8

10 years ago
> yes, it works. Though should we set 'selected' if tab has focused state?
Yes, we should for consistency.
(Assignee)

Comment 9

10 years ago
Created attachment 282541 [details] [diff] [review]
patch
Attachment #281799 - Attachment is obsolete: true
Attachment #282541 - Flags: review?(aaronleventhal)
Attachment #281799 - Flags: review?(aaronleventhal)
(Assignee)

Comment 10

10 years ago
(In reply to comment #7)
> Surkov, you can just to use your regular CVS account.

it looks I haven't permissions.
(Reporter)

Updated

10 years ago
Attachment #282541 - Flags: review?(aaronleventhal)
Attachment #282541 - Flags: review+
Attachment #282541 - Flags: approval1.9?

Updated

10 years ago
Attachment #282541 - Flags: approval1.9? → approval1.9+
(Reporter)

Comment 11

10 years ago
Surkov, when you check this in please also include information about this on the wiki:

You can put it under the section on the tab role.
http://developer.mozilla.org/en/docs/ARIA_to_API_mapping

"wairole:tab" -> ROLE_PAGETAB
    * Accessible name okay from children 
    * Selected state calculated by user agent, using the following algorithm: [explain]
(Reporter)

Comment 12

10 years ago
Also, please file a bug on mozilla.org site content to give you CVS write permissions there and CC me.
(Assignee)

Comment 13

10 years ago
(In reply to comment #12)
> Also, please file a bug on mozilla.org site content to give you CVS write
> permissions there and CC me.
> 

I filed a bug 398349.
(Assignee)

Comment 14

10 years ago
checked in, documentation is updated
Status: ASSIGNED → RESOLVED
Last Resolved: 10 years ago
Resolution: --- → FIXED
(Assignee)

Comment 15

10 years ago
(In reply to comment #3)

> Can you fix the Mozilla testcase so it uses labelledby?
> http://www.mozilla.org/access/dhtml/tabpanel
> 

Do I need review before landing? I guess, no?
(Reporter)

Comment 16

10 years ago
No, you don't need review before landing changes to the a11y testcases.
You need to log in before you can comment on or make changes to this bug.