Closed Bug 396424 Opened 17 years ago Closed 17 years ago

Calculate selected state for currently active ARIA tab

Categories

(Core :: Disability Access APIs, defect)

Product:
Core
Component:
Disability Access APIs
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED

People

(Reporter: aaronlev, Assigned: surkov)

References

(Blocks 1 open bug)

Details

(Keywords: access)

Attachments

(2 files, 1 obsolete file)

testcase
10.58 KB, application/xhtml+xml
Details
patch
1.93 KB, patch
aaronlev
: review+
damons
: approval1.9+
Details | Diff | Splinter Review
An ARIA tab should have STATE_SELECTED if the current focus (gLastFocusedNode) is inside the tab container it is a label for.
Attached patch like this? (obsolete) — — Splinter Review
Attachment #281799 - Flags: review?(aaronleventhal)
testcase http://test.cita.uiuc.edu/aria/tabpanel/tabpanel1.php, but not sure how to test it due to focus is changed.
Comment on attachment 281799 [details] [diff] [review] like this? The code looks good but we need to test it. What do you mean focus has changed? Can you fix the Mozilla testcase so it uses labelledby? http://www.mozilla.org/access/dhtml/tabpanel
Comment on attachment 281799 [details] [diff] [review] like this? Clearing review until we get test results.
Attachment #281799 - Flags: review?(aaronleventhal)
Attached file testcase —
yes, it works. Though should we set 'selected' if tab has focused state?
Assignee: aaronleventhal → surkov.alexander
Status: NEW → ASSIGNED
Attachment #281799 - Flags: review?(aaronleventhal)
(In reply to comment #3) > Can you fix the Mozilla testcase so it uses labelledby? > http://www.mozilla.org/access/dhtml/tabpanel > How can I do it? Should I have special rights?
Surkov, you can just to use your regular CVS account. See http://www.mozilla.org/contribute/writing/cvs You can check out the mozilla.org content tree with cvs co MozillaOrgTrim To get the mozilla.org/access tree I think you'll need to cd docs/mozilla-org/html cvs up -d access
> yes, it works. Though should we set 'selected' if tab has focused state? Yes, we should for consistency.
Attached patch patch — — Splinter Review
Attachment #281799 - Attachment is obsolete: true
Attachment #282541 - Flags: review?(aaronleventhal)
Attachment #281799 - Flags: review?(aaronleventhal)
(In reply to comment #7) > Surkov, you can just to use your regular CVS account. it looks I haven't permissions.
Attachment #282541 - Flags: review?(aaronleventhal)
Attachment #282541 - Flags: review+
Attachment #282541 - Flags: approval1.9?
Attachment #282541 - Flags: approval1.9? → approval1.9+
Surkov, when you check this in please also include information about this on the wiki: You can put it under the section on the tab role. http://developer.mozilla.org/en/docs/ARIA_to_API_mapping "wairole:tab" -> ROLE_PAGETAB * Accessible name okay from children * Selected state calculated by user agent, using the following algorithm: [explain]
Also, please file a bug on mozilla.org site content to give you CVS write permissions there and CC me.
(In reply to comment #12) > Also, please file a bug on mozilla.org site content to give you CVS write > permissions there and CC me. > I filed a bug 398349.
checked in, documentation is updated
Status: ASSIGNED → RESOLVED
Closed: 17 years ago
Resolution: --- → FIXED
(In reply to comment #3) > Can you fix the Mozilla testcase so it uses labelledby? > http://www.mozilla.org/access/dhtml/tabpanel > Do I need review before landing? I guess, no?
No, you don't need review before landing changes to the a11y testcases.
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: