396428 - ByteArray isn't the correct endianness on non-windows x86

Status: VERIFIED FIXED

(Tamarin Graveyard :: Virtual Machine, defect)

Description

[Benjamin Smedberg]

Attachment: #ifdef more correctly for processors, not OSes, rev. 1

The ByteArray type isn't the right native endianness on non-windows x86. This is because of a bad #ifdef in shell/DataIO.h. Trivial patch attached.

Comment 1

[Benjamin Smedberg]

Fixed on trunk, changeset 165 (049a855c8d5a)

Comment 2

[Mark Hammond [:markh] [:mhammond] [PTO until Sept 7]]

The patch caused VS8 builds to fail in the same way: "unknown format xxxx".  This implies __i386__ isn't defined by VS8.  It appears that Tamarin sets up its own architecture #defines which are used in a number of other places, so changing that line to:

\t\t\t#if defined(AVMPLUS_IA32) || defined(AVMPLUS_AMD64)

might be a better fix?

Comment 3

[Benjamin Smedberg]

I don't know. I've only been using the XP build system (where this works fine on VC8).

Comment 4

[Mark Hammond [:markh] [:mhammond] [PTO until Sept 7]]

Thomas, could you please offer your opinion on my proposed fix?  Ideally, if you have a Windows box available, it would be great if you could confirm or deny that it is currently broken on XP and needs *some* fix?

Comment 5

[Tommy Reilly]

ideally we'd have an endianess define and the selection would take place in avmplus.h, basing it on AVMPLUS_IA32 and AVMPLUS_AMD64 sounds right.

Comment 6

[Mark Hammond [:markh] [:mhammond] [PTO until Sept 7]]

Thanks - checked in 212:0bcb951fa3dd