Expose object attribute to explain when a text object ends in a newline

RESOLVED FIXED

Status

()

RESOLVED FIXED
11 years ago
11 years ago

People

(Reporter: aaronlev, Assigned: aaronlev)

Tracking

(Blocks: 1 bug, {access})

Trunk
access
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

11 years ago
The following elements create text which automatically get an effective newline after them:
h1-h6, div, p, li, caption, ...

I'm not sure the complete list, but it can just be based on the display: type (block, list-item, caption, etc.)

We should expose an object attribute "autolinebreaks" = "true" 

Otherwise the AT needs to use the bounds of the object to determine this.
(Assignee)

Comment 1

11 years ago
Created attachment 283844 [details] [diff] [review]
Use object attribute formatting: block

When we check this in we need to change our docs as well.
Attachment #283844 - Flags: review?(surkov.alexander)
Comment on attachment 283844 [details] [diff] [review]
Use object attribute formatting: block

(In reply to comment #0)

> We should expose an object attribute "autolinebreaks" = "true" 

aAttributes->SetStringProperty(NS_LITERAL_CSTRING("formatting"), NS_LITERAL_STRING("block"),
>+                                   oldValueUnused);

What is correct?

But in any way patch looks ok.
Attachment #283844 - Flags: review?(surkov.alexander)
Attachment #283844 - Flags: review+
Attachment #283844 - Flags: approval1.9?
(Assignee)

Comment 3

11 years ago
The one in the patch is correct. Mick and I decided the new name was better.
(Assignee)

Updated

11 years ago
Attachment #283844 - Flags: approval1.9?
(Assignee)

Updated

11 years ago
Attachment #283844 - Flags: approval1.9?

Updated

11 years ago
Attachment #283844 - Flags: approval1.9? → approval1.9+
(Assignee)

Updated

11 years ago
Status: NEW → RESOLVED
Last Resolved: 11 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.