Closed
Bug 396439
Opened 17 years ago
Closed 17 years ago
addBroadcastListenerFor should not require callers to synchronise attributes manually first
Categories
(Core :: XUL, defect)
Core
XUL
Tracking
()
RESOLVED
DUPLICATE
of bug 391002
People
(Reporter: neil, Assigned: neil)
Details
Attachments
(1 file)
|
1.54 KB,
patch
|
jst
:
review+
|
Details | Diff | Splinter Review |
Spun off bug 395496.
addBroadcastListenerFor calls SynchroniseBroadcastListener which calls SetAttr with an aNotify of PR_FALSE, which is only useful on document construction. GetDidInitalReflow would return a more useful aNotify value.
|
Assignee | |
Comment 1•17 years ago
|
||
Assignee: nobody → neil
Status: NEW → ASSIGNED
Attachment #281250 -
Flags: superreview?(jonas)
Attachment #281250 -
Flags: review?(jst)
|
||
Updated•17 years ago
|
Attachment #281250 -
Flags: review?(jst) → review+
This patch looks odd to me, what does initial reflow have to do with anything?
Comment on attachment 281250 [details] [diff] [review]
Proposed patch
Removing review request waiting for reply to previous comment. Looks like this patch might not be relevant any more though.
Please do note that calling SetAttr with aNotify set to true might execute script, so you should be prepared for the world going away under you.
Attachment #281250 -
Flags: superreview?(jonas)
|
|
Assignee | |
Comment 4•17 years ago
|
||
(In reply to comment #2)
>This patch looks odd to me, what does initial reflow have to do with anything?
It's what overlays use to see if they should notify, see nsXULDocument ::
OverlayForwardReference. Maybe they should use mInitialLayoutComplete too?
(In reply to comment #3)
>(From update of attachment 281250 [details] [diff] [review])
>Looks like this patch might not be relevant any more though.
Status: ASSIGNED → RESOLVED
Closed: 17 years ago
Resolution: --- → DUPLICATE
Component: XP Toolkit/Widgets: XUL → XUL
QA Contact: xptoolkit.xul → xptoolkit.widgets
You need to log in
before you can comment on or make changes to this bug.
Description
•