396491 - actions menu for feed type in Applications prefpane loses focus upon selection

Status: RESOLVED FIXED

(Firefox :: File Handling, defect)

Description

[Myk Melez [:myk] [@mykmelez]]

When you select an item in the actions menu for the feed type in the Applications prefpane, the menu loses focus.  For other types, the menu retains focus.  It should retain focus for the feed type as well.

Comment 1

[Myk Melez [:myk] [@mykmelez]]

Requesting wanted-1.9 for this Applications prefpane polish fix.

Comment 2

[Myk Melez [:myk] [@mykmelez]]

Attachment: patch v1: simplest fix for problem

This may not be the best solution, but it's the only simple one I can think of.  The others are all significantly more complicated.

When the user selects an item from the dropdown menu for the feed type, the prefpane controller twiddles some feed handler info properties, which update feed preferences, which spawn "pref changed" notifications, which are observed by the prefpane controller, which rebuilds the view, wiping out the focus.

It's unnecessary to rebuild the view in this case, since the view gets updated as needed in onSelectAction.  The solution in this patch is to set a flag indicating that an action is in the process of being stored and suppress "pref changed" view rebuilds when the flag is set.

Comment 3

[Myk Melez [:myk] [@mykmelez]]

Attachment: patch v2: unrotted

Comment 4

[Myk Melez [:myk] [@mykmelez]]

Comment on attachment 285265 [details] [diff] [review]
patch v2: unrotted

Requesting approval for this wanted bug.  This patch is small, simple, well-isolated, and thus low-risk.

Comment 5

[Myk Melez [:myk] [@mykmelez]]

Checking in browser/components/preferences/applications.js;
/cvsroot/mozilla/browser/components/preferences/applications.js,v  <--  applications.js
new revision: 1.26; previous revision: 1.25
done