Closed Bug 396517 Opened 17 years ago Closed 17 years ago

nsPopupBoxObject::EnableKeyboardNavigator seems to be backward

Categories

(Core :: XUL, defect)

Product:
Core
Component:
XUL
Platform:
x86
Linux
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED

People

(Reporter: bzbarsky, Assigned: enndeakin)

References

Details

(Keywords: regression)

Attachments

(1 file)

switch state and add a test
5.47 KB, patch
bzbarsky
: review+
bzbarsky
: superreview+
roc
: approval1.9+
Details | Diff | Splinter Review 
See bug 279703 comment 105.  Looking at the code, it does seem to be backwards.
Flags: blocking1.9?

        Attachment #281460 -
        Flags: superreview?(bzbarsky)

        Attachment #281460 -
        Flags: review?(bzbarsky)

    
    

    
  
Comment on attachment 281460 [details] [diff] [review]
switch state and add a test

Looks good.  r+sr=bzbarsky

        Attachment #281460 -
        Flags: superreview?(bzbarsky)

        Attachment #281460 -
        Flags: superreview+

        Attachment #281460 -
        Flags: review?(bzbarsky)

        Attachment #281460 -
        Flags: review+

    
  

        Attachment #281460 -
        Flags: approval1.9?

    
  
Status: NEW → RESOLVED
Closed: 17 years ago
Flags: in-testsuite+
Resolution: --- → FIXED

    
  
Component: XP Toolkit/Widgets: Menus → XUL
QA Contact: xptoolkit.menus → xptoolkit.widgets

          You need to log in
          before you can comment on or make changes to this bug.
        






  

    
  







  

    

      
Attachment

      

      
      
      
      
    

    

      

        

          

            
General

            

              Creator: 



            

            
Created: 

            
Updated: 

            
Size: