396584 - ecma_3/Function/arguments-002.js FAIL

Status: VERIFIED FIXED

(Core :: JavaScript Engine, defect, P1)

Description

[Bob Clary [:bc] (inactive)]

Caused by attachment 268559 [details] [diff] [review] in bug 383269 comment 44

Expected value '33,42:33', Actual value '33,[object Object]:33'

Comment 1

[Bob Clary [:bc] (inactive)]

I hate regressions but since finding them and getting them fixed gives my life meaning, nominating for 1.9.

Comment 2

[Brendan Eich [:brendan]]

Either call_resolve must resolve arguments whether or not JOF_ASSIGNING (aka JOF_SET) is set for JSOP_BINDNAME, or JSOP_BINDNAME should not have that flag in its opcode format.

Independently, we should reduce redundant JOF_SET|...JOF_ASSIGNING to JOF_SET in jsopcode.tbl.

/be

Comment 3

[Brendan Eich [:brendan]]

When a property becomes lazily bound *without JSPROP_SHARED* in a prototype via a class resolve hook, and that property has a setter (whether specialized or class setProperty hook, doesn't matter) that must run even when the property is being set in a delegating object (which normally shadows the proto-property, making its setter uninteresting), then resolve must not filter on JSRESOLVE_ASSIGNING.

So I am going to attempt a minimal change to call_resolve and leave jsopcode.tbl alone until bug 407954 (someone please grab that, it's trivial but nice to have).

/be

Comment 4

[Brendan Eich [:brendan]]

Attachment: minimal fix

diff -w version next.

Bob, could you please test this hard? I haven't got a good baseline and have other commitments, so could use a proof that this doesn't regress any  fixed bugs.

/be

Comment 5

[Brendan Eich [:brendan]]

Attachment: diff -w version of last attachment

Comment 6

[Bob Clary [:bc] (inactive)]

(In reply to comment #4)
> 
> Bob, could you please test this hard?

can do today.

Comment 7

[Brendan Eich [:brendan]]

Fixed, optimizing for the case where the patch does indeed cause no regressions:

js/src/jsfun.c 3.240

Please file a followup bug if there is an apparent regression. Thanks,

/be

Comment 9

[Bob Clary [:bc] (inactive)]

Looks good on the test tinderboxen for shell linux, macppc. I'll verify when I do better os coverage and have browser results.

Comment 10

[Bob Clary [:bc] (inactive)]

verified fixed 1.9.0

Checking in public-failures.txt;
/cvsroot/mozilla/js/tests/public-failures.txt,v  <--  public-failures.txt
new revision: 1.10; previous revision: 1.9
done