396653 - Get rid of lib/asn1

Status: RESOLVED FIXED

(NSS :: Libraries, defect, P2)

Description

[Julien Pierre]

This is purely dead code. Can we cvs remove all the files ?
I spent time patching some stuff in it that didn't need to be.
I propose doing that for both the trunk and the current NSS_3_11_BRANCH .

Comment 1

[Nelson Bolyard (seldom reads bugmail)]

I favor expunging dead code from NSS.

Comment 2

[Julien Pierre]

Bob, do you agree ?

Comment 3

[Robert Relyea]

If we truly don't use it, it gives us 6k back;).

Comment 4

[Julien Pierre]

Attachment: Remove lib/asn1 source files and omit it from lib/config.mk

Bob,

This doesn't even give us 6 KB back because none of the objects were being linked anywhere. The main benefits of this patch are to make our checkouts and compiles faster, as well as for us not to waste time trying to maintain dead source code when we make changes that affect the whole tree. I found out about this dead code while working on util.

Comment 5

[Nelson Bolyard (seldom reads bugmail)]

Comment on attachment 286905 [details] [diff] [review]
Remove lib/asn1 source files and omit it from lib/config.mk

r=nelson

Comment 6

[Robert Relyea]

Comment on attachment 286905 [details] [diff] [review]
Remove lib/asn1 source files and omit it from lib/config.mk

r+ rrelyea

Comment 7

[Julien Pierre]

Thanks Bob.

I checked this patch in to the trunk :

Removing Makefile;
/cvsroot/mozilla/security/nss/lib/asn1/Makefile,v  <--  Makefile
new revision: delete; previous revision: 1.5
done
Removing asn1.c;
/cvsroot/mozilla/security/nss/lib/asn1/asn1.c,v  <--  asn1.c
new revision: delete; previous revision: 1.4
done
Removing asn1.h;
/cvsroot/mozilla/security/nss/lib/asn1/asn1.h,v  <--  asn1.h
new revision: delete; previous revision: 1.3
done
Removing asn1m.h;
/cvsroot/mozilla/security/nss/lib/asn1/asn1m.h,v  <--  asn1m.h
new revision: delete; previous revision: 1.3
done
Removing asn1t.h;
/cvsroot/mozilla/security/nss/lib/asn1/asn1t.h,v  <--  asn1t.h
new revision: delete; previous revision: 1.4
done
Removing config.mk;
/cvsroot/mozilla/security/nss/lib/asn1/config.mk,v  <--  config.mk
new revision: delete; previous revision: 1.4
done
Removing manifest.mn;
/cvsroot/mozilla/security/nss/lib/asn1/manifest.mn,v  <--  manifest.mn
new revision: delete; previous revision: 1.6
done
Removing nssasn1t.h;
/cvsroot/mozilla/security/nss/lib/asn1/nssasn1t.h,v  <--  nssasn1t.h
new revision: delete; previous revision: 1.3
done

Checking in manifest.mn;
/cvsroot/mozilla/security/nss/lib/manifest.mn,v  <--  manifest.mn
new revision: 1.18; previous revision: 1.17
done

And to NSS_3_11_BRANCH :

Checking in manifest.mn;
/cvsroot/mozilla/security/nss/lib/manifest.mn,v  <--  manifest.mn
new revision: 1.16.2.1; previous revision: 1.16
done
Removing asn1/Makefile;
/cvsroot/mozilla/security/nss/lib/asn1/Attic/Makefile,v  <--  Makefile
new revision: delete; previous revision: 1.5
done
Removing asn1/asn1.c;
/cvsroot/mozilla/security/nss/lib/asn1/Attic/asn1.c,v  <--  asn1.c
new revision: delete; previous revision: 1.4
done
Removing asn1/asn1.h;
/cvsroot/mozilla/security/nss/lib/asn1/Attic/asn1.h,v  <--  asn1.h
new revision: delete; previous revision: 1.3
done
Removing asn1/asn1m.h;
/cvsroot/mozilla/security/nss/lib/asn1/Attic/asn1m.h,v  <--  asn1m.h
new revision: delete; previous revision: 1.3
done
Removing asn1/asn1t.h;
/cvsroot/mozilla/security/nss/lib/asn1/Attic/asn1t.h,v  <--  asn1t.h
new revision: delete; previous revision: 1.4
done
Removing asn1/config.mk;
/cvsroot/mozilla/security/nss/lib/asn1/Attic/config.mk,v  <--  config.mk
new revision: delete; previous revision: 1.4
done
Removing asn1/manifest.mn;
/cvsroot/mozilla/security/nss/lib/asn1/Attic/manifest.mn,v  <--  manifest.mn
new revision: delete; previous revision: 1.5
done
Removing asn1/nssasn1t.h;
/cvsroot/mozilla/security/nss/lib/asn1/Attic/nssasn1t.h,v  <--  nssasn1t.h
new revision: delete; previous revision: 1.3
done