Closed
Bug 396667
Opened 17 years ago
Closed 17 years ago
Task dialog: clicking the timezone url behind the start date -> no timezone dialog
Categories
(Calendar :: General, defect)
Calendar
General
Tracking
(Not tracked)
VERIFIED
FIXED
0.7
People
(Reporter: andreas.treumann, Assigned: michael.buettner)
Details
Attachments
(1 file, 1 obsolete file)
4.76 KB,
patch
|
mschroeder
:
review+
|
Details | Diff | Splinter Review |
STEPS TO REPRODUCE: =================== 1. Open the task dialog 2. open the options menu and check the timezone entry 3. mark only the start date checkbox of this task 4. mouseclick the timezone url behind the start date RESULT: ======= - the timezone dialog doesn't start JS console: Error: gEndTime has no properties Source File: chrome://calendar/content/sun-calendar-event-dialog.js Line: 1913 EXPECTED RESULT: ================ - mouseclicking the timezone url should open the timezone dialog REPRODUCIBLE: ============= - always Same scenario with the due date works without problems
Assignee | ||
Comment 1•17 years ago
|
||
Ups, regression from bug 370435.
Assignee: nobody → michael.buettner
Assignee | ||
Comment 2•17 years ago
|
||
The function editTimezone() has been introduced with Bug 370435 in order to consolidate the functions editStartTimezone() and editEndTimezone(). Always accessing gEndTime was a copy'n'paste bug, since the function just needs to use the 'aDateTime' argument as the timezone conversion and selection of the correct datetime object already happens before this function gets called.
Attachment #281449 -
Flags: review?(mschroeder)
Updated•17 years ago
|
Target Milestone: --- → 0.7
Version: Trunk → unspecified
Assignee | ||
Comment 3•17 years ago
|
||
This updated version of the patch also enables/disables the entire timezone link(s) according to the entrydate/duedate checkboxes.
Attachment #281449 -
Attachment is obsolete: true
Attachment #281461 -
Flags: review?(mschroeder)
Attachment #281449 -
Flags: review?(mschroeder)
Comment 4•17 years ago
|
||
Comment on attachment 281461 [details] [diff] [review] patch v2 r=mschroeder
Attachment #281461 -
Flags: review?(mschroeder) → review+
Assignee | ||
Comment 5•17 years ago
|
||
patch checked in on trunk and MOZILLA_1_8_BRANCH -> FIXED
Status: NEW → RESOLVED
Closed: 17 years ago
Resolution: --- → FIXED
Reporter | ||
Comment 6•17 years ago
|
||
Checked in Lightning build 2007092103 and Sunbird build 20070920 -> VERIFIED
Status: RESOLVED → VERIFIED
You need to log in
before you can comment on or make changes to this bug.
Description
•