396789 - talos sometimes mangles url names

Status: RESOLVED FIXED

(Release Engineering :: General, defect)

Description

[alice nodelman [:alice] [:anode]]

Attachment: fix up some name mangling

If you switch talos over to run through web pages from the live web it gets results of 'www.yahoo.com/', when attempting to convert that to standard format it ends up splitting over the '/' and returning 'undefined' as the url name.

This patch strips off trailing '/' from urls to stop this behavior.

Comment 1

[[e-mail] (:bhearsum)]

Comment on attachment 281550 [details] [diff] [review]
fix up some name mangling

This seems fine. I think there's a typo in the existing code, though.
     if (res.find('tp') > -1) or (res == 'tdhmtl'):

I think 'tdhmtl' should be 'tdhtml'.

Comment 2

[alice nodelman [:alice] [:anode]]

Attachment: fix for name mangling, fix for mispelled tdhtml

Added a fix for tdhtml misspelling, by just replacing that line with an 'else' - which also helps with integrating the stand alone tests.

Comment 3

[[e-mail] (:bhearsum)]

Comment on attachment 281755 [details] [diff] [review]
fix for name mangling, fix for mispelled tdhtml

Looks good.

Comment 4

[alice nodelman [:alice] [:anode]]

Checking in run_tests.py;
/cvsroot/mozilla/testing/performance/talos/run_tests.py,v  <--  run_tests.py
new revision: 1.11; previous revision: 1.10
done

Comment 5

[(not currently active) Ted Mielczarek]

Mass move of Core:Testing bugs to mozilla.org:Release Engineering:Talos. Filter on RelEngTalosMassMove to ignore.