396810 - Don't show the reply box in the forum as feedback to anonymous users

Status: VERIFIED FIXED

(support.mozilla.org :: Forum, task)

Description

[Jason Barnabe (np)]

Anonymous forums users get the following heading above the reply box in the forums:

"Thanks for your feedback. Have more to tell us?"

They should instead get the same heading as other users, which should be "Post a reply"

Comment 1

[Jason Barnabe (np)]

Attachment: patch

Comment 2

[Jason Barnabe (np)]

Attachment: wiki-feedpack.tpl

Comment 3

[Jason Barnabe (np)]

Generally, I want the feedback thread on page discussions and threads in the forum to be the same. The only difference so far should be that anonymous users on page discussions should only get the poll/textarea and not see the discussion.

This patch
-Splits the poll/textarea code out of comments.tpl, which is shared by forum threads, into a new file wiki-feedback.tpl,
-Modifies tiki-page_bar.tpl to show wiki-feedback.tpl instead of comments.tpl for anonymous users
-Splits the styling for poll/textarea and regular replies. Poll/textarea is now affected by the "feedbackbox" set of styles, while regular replies are "commentbox".
-Changes comments.tpl to more sensible - only one header, re-enables preview, takes out the table-based layout, puts the submit button inside the box, and fixes code indentation is some spots
-Fixes the poll/textarea code so that the textarea doesn't overlap the third column.

Everything looks fine to me, but I wasn't able to test the captcha stuff because that doesn't work locally.

Comment 4

[Jason Barnabe (np)]

Attachment: updated patch

Last patch got rotted by the captcha change. This one's a little different.

-Splits the poll/textarea code out of comments.tpl, which is shared by forum
threads, into a new file wiki-feedback.tpl,
-Modifies tiki-page_bar.tpl to show wiki-feedback.tpl instead of comments.tpl
for anonymous users
-For article feedback, only the poll is shown initially. When the user chooses an option, the poll disappears and the text feedback box appears.
-Captcha shows when the user begins typing instead of when they press Submit.
-Included some explanatory text for text feedback "Your feedback will be used to improve this article. If you're looking for more help, see the Need More Help? box on the right of this page.".
-Text feedback shows as a gray box instead of a speech bubbly white box

Comment 5

[Jason Barnabe (np)]

Attachment: wiki-feedpack.tpl

Comment 6

[Nelson Ko [:nkoth]]

Good idea. I will be rewriting the ajax parts with MooTools (which is the js library used in Tiki) though.

Comment 7

[Jason Barnabe (np)]

Can you put this in before you do that though? I want to start making patches for the forum and this is blocking me.

Also, do you know what changes we've made to the comments.tpl compared to upstream? The article threading options don't work so I'm wondering if we should just revert all the changes to comments.tpl and start from that.

Comment 8

[Jason Barnabe (np)]

Nelson, can you give me an ETA on landing this patch?

Comment 9

[Nelson Ko [:nkoth]]

I will put this in tomorrow (Wed 28) in its current form, without any changes on AJAX/mootools/changes to comments.tpl.

As for the comments.tpl in general, I will look at that over the next two days and develop a strategy.

Comment 10

[Nelson Ko [:nkoth]]

ok. I've just committed this with the following changes:

1. Make "Yes" and "No" text closer to radio button.
2. Make sure shrink-wrap works in IE as well.
3. Rename "thanks" class to "commentboxhead" which better describes what it is when logged in instead of removing style from stylesheet.
4. Remove old javascript from submit button in comments.tpl.
5. Make submit button disabled until things are typed in to prevent submission of empty comment.

Comment 11

[Nelson Ko [:nkoth]]

Jason,

I have reverted comments.tpl to essentially the one that is in 1.10. I've also added the necessary 1.10 forum styles to the style sheet (at the end). You should be able to continue adding patches re forum now. 

Let me know if you need anything else.

Comment 12

[Louis-Philippe Huberdeau]

Isn't this sumo specific?

There is no such thing as tiki-feedback. What is it used for? Which feature is it part of?

Comment 13

[David Tenser [:djst]]

This looks like the article feedback form at the bottom of each article that logged out users see (see the "Submit additional feedback" link at the bottom of this article: http://support.mozilla.com/en-US/kb/Will+Firefox+work+on+Windows+7).

Is that feature upstreamed? If so, this bug is sumo_only.

Comment 14

[Louis-Philippe Huberdeau]

It's not upstreamed at this time. It could probably be, but I need to understand the purpose of it.

Does it do anything on it's own?
How is it different from comments?