396914 - Prefwindow is corrupted if it has multi panes and contains tree

Status: RESOLVED FIXED

(Toolkit :: Preferences, defect)

Description

[Gomita]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; ja; rv:1.8.1.6) Gecko/20070725 Firefox/2.0.0.6
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; ja; rv:1.9a8pre) Gecko/2007092005 Minefield/3.0a8pre

xul:prefwindow is corrupted if it has more than two xul:prefpane elements and one of them contains xul:tree.
This is a regression after the checked-in of Bug 283697.

Reproducible: Always

Comment 1

[Gomita]

Attachment: testcase

Comment 2

[Robert Strong (they/them - no direct email)]

Have you tested this on Mac OS X prior to bug 283697 landing?

Comment 3

[Robert Strong (they/them - no direct email)]

Reporter, please try reproducing with a recent hourly build or the next nightly build.

Comment 4

[Gomita]

Attachment: evidence

I tested on the latest hourly 3.0a9pre build but still have same problem.
Mozilla/5.0 (Windows; U; Windows NT 5.1; ja; rv:1.9a8pre) Gecko/2007092119 Minefield/3.0a9pre

And sorry, I've never tested on Mac OS X.

Comment 5

[Robert Strong (they/them - no direct email)]

Can you provide the full code that accomplishes this? The testcase throws using the prefwindow since not all of the elements required for the prefwindow are available in the testcase.

Comment 6

[Robert Strong (they/them - no direct email)]

A link to download the extension or XULRunner app would be best

Comment 7

[Gomita]

Attachment: Testcase as a simple extension

I created a testcase as a very simple extension.
Install it, go [Tools] > [Options] > [Testcase], press [Options] button to reproduce the bug.

Comment 8

[Gomita]

sorry,
- go [Tools] > [Options] > [Testcase]
+ go [Tools] > [Add-ons] > [Testcase]

Comment 9

[Robert Strong (they/them - no direct email)]

I'm unsure when I will be able to look at a possible solution. The one thing that stands out is that the prefwindow requires min-height (preferred on trunk) or height (preferred on branch) to be set for the prefwindow when animateFadeIn is false. If you want to support animateFadeIn (default on Mac OS X and works on all platforms now) you would need to use min-height on trunk. Also, Bug 396121 added the ability to check if animateFadIn is true on the trunk.

Comment 10

[Gomita]

I added width, height, min-width and min-height to prefwindow / prefpane elements but still have the problem.
I look at preferences.xml and guess window.sizeToContent(); in line 706 causes the problem.
Just commenting out it and adding return; to the next line seems to solve the problem on Windows and Linux, although the animatedFadeIn is disabled instead.

Comment 11

[Robert Strong (they/them - no direct email)]

Please take a look at how the applications make use of the prefwindow.

http://lxr.mozilla.org/seamonkey/source/browser/components/preferences/preferences.xul
http://lxr.mozilla.org/seamonkey/source/browser/themes/winstripe/browser/preferences/preferences.css
http://lxr.mozilla.org/seamonkey/source/browser/themes/pinstripe/browser/preferences/preferences.css

and the other xul files under
http://lxr.mozilla.org/seamonkey/source/browser/components/preferences/

Comment 12

[Gomita]

The bug have been fixed since the following checkins:
http://hourly-archive.localgho.st/win32/20071001_2141_checkins.html