396983 - nsXULPopupManager::ShowPopup (or callers) should flush frames

Status: RESOLVED FIXED

(Core :: XUL, defect)

Description

[:Gavin Sharp [email: [e-mail]]]

See bug 395314: trying to unhide and then open a popup doesn't currently work without forcing frame construction or using a setTimeout hack. nsXULPopupManager::ShowPopup should probably FlushPendingNotifications().

Comment 1

[Boris Zbarsky [:bzbarsky]]

Or nsPopuBoxObject::ShowPopup should if the other caller of nsXULPopupManager::ShowPopup can't deal.

Comment 2

[Neil Deakin]

Sounds like nsXULPopupManager::GetFrameOfTypeForContent could just take a shouldFlush argument which flushes before retrieving the frame.
 

Comment 3

[Neil Deakin]

Attachment: flush the frames before showing a popup

Comment 4

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 283469 [details] [diff] [review]
flush the frames before showing a popup

A flush can run arbitrary script.  In particular, the presshell can be dead here after the flush...

I assume all consumers are OK with random script running here, right?

Comment 5

[Neil Deakin]

(In reply to comment #4)
> (From update of attachment 283469 [details] [diff] [review])
> A flush can run arbitrary script.  In particular, the presshell can be dead
> here after the flush...

Ah, yes. So it should be ok to keep a strong reference to the presshell right?

> I assume all consumers are OK with random script running here, right?

Yes, the callers are expecting synchronous event handling so scripts will already be exected to run.

Comment 6

[Boris Zbarsky [:bzbarsky]]

> Ah, yes. So it should be ok to keep a strong reference to the presshell right?

Yeah, I think that should be enough.

Comment 7

[Neil Deakin]

Attachment: keep a strong reference to the presshell

Comment 8

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 283761 [details] [diff] [review]
keep a strong reference to the presshell

r+sr=bzbarsky

Comment 9

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Comment on attachment 283761 [details] [diff] [review]
keep a strong reference to the presshell

a1.9=dbaron