Closed Bug 397135 Opened 13 years ago Closed 13 years ago

tree._ensureColumnOrder dies if no columns are defined

Categories

(Toolkit :: XUL Widgets, defect)

defect
Not set

Tracking

()

RESOLVED FIXED

People

(Reporter: mnyromyr, Assigned: mnyromyr)

References

Details

Attachments

(1 file, 1 obsolete file)

Attached patch easy fix (obsolete) — Splinter Review
DOM-Manipulating a <tree> without any <treecol> elements (yet) results in:

JavaScript error: chrome://global/content/bindings/tree.xml, line 134: this.columns has no properties
Attachment #281909 - Flags: review?(gavin.sharp)
Attached patch better fixSplinter Review
Assignee: nobody → mnyromyr
Attachment #281909 - Attachment is obsolete: true
Status: NEW → ASSIGNED
Attachment #281929 - Flags: review?(gavin.sharp)
Attachment #281909 - Flags: review?(gavin.sharp)
Attachment #281929 - Flags: review?(gavin.sharp) → review+
Comment on attachment 281929 [details] [diff] [review]
better fix

Asking approval for simple null pointer check.
Attachment #281929 - Flags: approval1.9?
Attachment #281929 - Flags: approval1.9? → approval1.9+
Landed on trunk.
Status: ASSIGNED → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.