397155 - cd fails in toolkit/mozapps/extensions/test/unit/addons/

Status: RESOLVED FIXED

(Firefox Build System :: General, defect)

Description

[jag (Peter Annema)]

/bin/sh: line 1: cd: ../../../../../mozilla/toolkit/mozapps/extensions/test/unit/addons/test_bug394300_2: No such file or directory
  adding: CVS/ (stored 0%)
  adding: install.rdf (deflated 69%)

The above is repeated once for every dir in the addons dir.

The code in the Makefile cds into the test's source directory and zips up its contents into a corresponding xpi file in $objdir/_tests/xpcshell-simple/test_extensionmanager/unit/addons/

Unfortunately the way it cds into the test's source directory is through the path had from $(ADDONSRC), which (in my setup) is relative to the objdir it's in. The first cd will succeed, but the second and onward fail because the relative path won't resolve, due to different depth levels. The fix is relatively simple, just execute the cd and zip in a subshell.

Comment 1

[jag (Peter Annema)]

Attachment: Execute cd and zip in subshell

I connected the cd and zip through && so nothing funky will happen if cd ever fails (e.g. someone puts a file there)

Comment 2

[Benjamin Smedberg]

Comment on attachment 281928 [details] [diff] [review]
Execute cd and zip in subshell

1) I'd prefer the subshell to be on the same line, e.g. (cd $$dir && zip...)
2) Can we add $(EXIT_ON_ERROR) to make this more sane?

Comment 3

[jag (Peter Annema)]

Attachment: Execute cd and zip in subshell

Something like this?

Comment 4

[jag (Peter Annema)]

Checking in Makefile.in;
/cvsroot/mozilla/toolkit/mozapps/extensions/test/Makefile.in,v  <--  Makefile.in
new revision: 1.2; previous revision: 1.1
done