39724 - XBM mime type ignored

Status: VERIFIED WORKSFORME

(Core :: Graphics: ImageLib, defect, P3)

Description

[[e-mail]]

When a data stream begins "#define " its mime type is set to "unknown."

This is because sniffout_mimetype returns PR_TRUE overriding the server type.

I assume this will prevent any future XBM decoder from working.

Comment 1

[pnunn]

No component is available for xbm yet.
Would you like to volunteer?
The source for the xbm decoding is available.
It just needs to be made into a component.

Comment 2

[[e-mail]]

I was considering it...

I'm not actually a C++ programmer although I do have some C and Java experience.

Also my PC is a bit short on disk space at the moment...

Comment 3

[John Vandenberg]

Looking at the list of image filetypes/extenstions in 
layout/html/base/src/nsObjectFrame.cpp, it indicates the following extensions 
are supported: gif,jpg,png,xbm
I am unable to load xbm files, and this looks like the cause.  It seems ironic 
that IE5 has support.
I am working on xpm support and it seems reasonable to get xbm to work at the 
same time, if its still a problem.

Comment 4

[pnunn]

There should not be a hard coded list in layout
about what image file formats are supported. It defeats
the whole purpose of the design of the image lib.

The current design allows you to add a new component
fairly easily. There are some problems in other modules
that make mapping the image file extension with the
image type awkward. There is already a bug on this.

And thanks for volunteering to create an XBM component. 
If you run into problems, let me know.

-P

Comment 5

[John Vandenberg]

nsObjectFrame::IsSupportedImage, is where I found the hard coded list, and its 
used in nsObjectFrame::Init.

Comments also indicate it "Ideally should be a call to imlib, when it is 
available"

http://lxr.mozilla.org/seamonkey/source/layout/html/base/src/nsObjectFrame.cpp#3
87

Where would I find the source you mention for xbm decoding?

Comment 6

[pnunn]

super.
Let me dig out that old XBM code.
-p

Comment 7

[pnunn]

Attachment: _very_ old source for xbm decoding

Comment 8

[pnunn]

The attached code is _old_, but works. It needs an
xpCOM wrapper. Take a look at the other decoder components
(gif,jpg,png) and All Will Be Revealed.

Also I poked around until I found code accessible via bonsai
that has an early version of the com wrapper. You can find this
at 

http://lxr.mozilla.org/classic/source/modules/libimg/src/xbm.cpp

Happy Sailing!
Feel free to assign this to yourself.
-p

Comment 9

[pnunn]

awww heck. I'll reassign it to you....

Comment 10

[Marek Z. Jeziorek]

an important embedding customer wants support for XBM. Could we get it done by
6.1 RTM? clearing TM

Comment 11

[[e-mail]]

Found a volunteer!

Comment 12

[Christian :Biesinger (don't email me, ping me on IRC)]

Looks like the XBM Mimetype is not ignored. When a decoder is added in the usual
way, it is used by imagelib.
So only the actual decoder needs to be written, which is bug 8031.

Marking WORKSFORME.

Comment 13

[Terri Preston]

Sounds good to me, marking verified

Comment 14

[[e-mail]]

The URL refers to libimg, I assume libpr0n doesn't have the same problem.