Type in editor/base/IMETextTxn.cpp?

VERIFIED FIXED in M17

Status

()

P3
normal
VERIFIED FIXED
19 years ago
17 years ago

People

(Reporter: Joerg.Brunsmann, Assigned: shanjian)

Tracking

Trunk
x86
FreeBSD
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

(URL)

(Reporter)

Description

19 years ago
Shouldn't 

if (otherTxn && NS_SUCCEEDED(NS_OK))

look like

if (otherTxn && NS_SUCCEEDED(result))

or

if (otherTxn)

??

Comment 2

19 years ago
assigning to ftang for confirmation on suggested change -- Frank, see line 167 
in the file
Assignee: beppe → ftang
Status: UNCONFIRMED → NEW
Ever confirmed: true

Comment 3

19 years ago
good catch ! shanjian, can you handl this ? 
Assignee: ftang → shanjian
Target Milestone: --- → M17
(Assignee)

Updated

19 years ago
Status: NEW → ASSIGNED
(Assignee)

Comment 4

19 years ago
I change the code and try it on my machine, it is correct.
I will checked it in when tree is open.
(Assignee)

Comment 5

19 years ago
Index: IMETextTxn.cpp
===================================================================
RCS file: /cvsroot/mozilla/editor/base/IMETextTxn.cpp,v
retrieving revision 1.20
diff -r1.20 IMETextTxn.cpp
167c167
<   if (otherTxn && NS_SUCCEEDED(NS_OK))
---
>   if (otherTxn && NS_SUCCEEDED(result))
(Assignee)

Comment 6

19 years ago
fix checked in.
Status: ASSIGNED → RESOLVED
Last Resolved: 19 years ago
Resolution: --- → FIXED

Comment 7

19 years ago
marking verified...code level fix.
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.