397322 - ITIP mails should be deleted after answering

Status: NEW

(Calendar :: E-mail based Scheduling (iTIP/iMIP), enhancement)

Description

[Hubert FONGARNAND]

User-Agent:       Mozilla/5.0 (X11; U; Linux i686; fr-FR; rv:1.8.1.7) Gecko/20070914 Firefox/2.0.0.7
Build Identifier: 

When you answer an Itip invitation in lightning the mails keep in Inbox. In other mails/calendar system (evolution or outlook) the Itip message is deleted

Reproducible: Always

Steps to Reproduce:
1.Reply to an Itip invitation
2.The message is still in Inbox
3.
Actual Results:  
The message is still in Inbox

Expected Results:  
It should be send to trash

Comment 1

[Pete Riley]

The problem that I see is that the email will be deleted before I have a chance to reply to it (e.g. to explain why I'm declining an invitation).  While I can train myself to always reply before I accept/decline, I don't think that this will be obvious for new users.

Comment 2

[Bas van den Bosch]

Or lightning should alter the message so the state of the invitation gets updated...

Comment 3

[Hubert FONGARNAND]

it could be an option in preferences (move ITIP/IMIP message after processing)?

Comment 4

[Bas van den Bosch]

I always disliked the way other programs deleted the emails. We offer the possibility to add additional text to invitation-emails so I think we should keep the messages. And, with Hubert fixes and the system we already have in place, the status of the message is always known. So I suggest setting this to wontfix.

Comment 5

[Hubert FONGARNAND]

If you do so... lightning will be the only one with the behaviour... It certainly would not help migration from proprietary programs. Why this behaviour couldn't be configurable? 

Comment 7

[wabik]

I agree it should be deleted, otherwise it is a big mess in the inbox :(

Comment 8

[wabik]

Nothing TBD ??

Comment 9

[Philipp Kewisch [:Fallen][📱📆]]

Valid request, confirming for now. This needs to be configurable and disabled by default though.

Comment 10

[[:MakeMyDay]]

Attachment: DeleteInvitationMailAfterProcessing-V1.diff

The patch provides a preference driven ability to delete imip messages once they are processed successfully. By default, the pref is disabled to stay with the current behaviour.

The applies on top of that to bug 782670.

Comment 11

[[:MakeMyDay]]

Attachment: DeleteInvitationMailAfterProcessing-V2.diff

Updated. I missed to clear out whitespaces. Sorry for double posting.

Comment 12

[Philipp Kewisch [:Fallen][📱📆]]

Comment on attachment 8413155 [details] [diff] [review]
DeleteInvitationMailAfterProcessing-V2.diff

Review of attachment 8413155 [details] [diff] [review]:
-----------------------------------------------------------------

The trouble I see with this patch is what might happen if processing takes a while. Lets say I start the accept/decline process, that takes a while due to a slow network connection, I switch to a different message, then onOperationComplete is called. The wrong message will be deleted. Also, there might be trouble with extensions like Thunderbird Conversations. I don't know if we can keep a reference to the message hdr when building up the imip bar and use that instead when deleting.

Also, I think this is worth a user-visible preference, and it would also be nice to have a mozmill test that covers this.

Comment 13

[[:MakeMyDay]]

I didn't thought about the slow calendar scenario, but you're right. Accidentally deleting a wrong e-mail would be inacceptable, even if this will occur with a low probability.

It was my first idea to read out the message-id and probably the related account-id and then make a deletion based on this. While capturing is quite easy, there seems to be no such general deletion functionality in TB, I can feed those data in later on - at least I didn't find any.

Maybe the search function provides an appropriate hook to get the right container where the message is currently located to perfom the deletion. I'll take a further look into this, once I got all my data back.